Draft
Conversation
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
…ethod Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
SergiiDmytruk
requested changes
Feb 20, 2026
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
Large number of comments, but most of them are trivial. Overall it's a good addition to the documentation that should clear things up for users.
| [Dasharo Trust Root](https://docs.dasharo.com/glossary/#dasharo-trustroot) | ||
| technology, it needs to be switched to the `Disabled (HAP)` state to perform the | ||
| update. Fwupd is unable to disable Intel ME automatically. This needs to be done | ||
| manually before the intent for updating the system. Afterwards, Intel ME needs |
Member
There was a problem hiding this comment.
Suggested change
| manually before the intent for updating the system. Afterwards, Intel ME needs | |
| manually before trying to update the system. Afterwards, Intel ME needs |
| update. Fwupd is unable to disable Intel ME automatically. This needs to be done | ||
| manually before the intent for updating the system. Afterwards, Intel ME needs | ||
| to be manually turned back on if desired. | ||
| Check [Intel Management Engine Options](../dasharo-menu-docs/dasharo-system-features/#intel-management-engine-options) |
Member
There was a problem hiding this comment.
Suggested change
| Check [Intel Management Engine Options](../dasharo-menu-docs/dasharo-system-features/#intel-management-engine-options) | |
| Check [Intel Management Engine Options](../dasharo-menu-docs/dasharo-system-features.md#intel-management-engine-options) |
| to be manually turned back on if desired. | ||
| Check [Intel Management Engine Options](../dasharo-menu-docs/dasharo-system-features/#intel-management-engine-options) | ||
| documentation for details on how to set ME mode to `Disabled (HAP)`. | ||
| See [this Knowledge Base article](../dasharo-menu-docs/dasharo-system-features.md#intel-management-engine-options) |
|
|
||
| ## Intel ME | ||
|
|
||
| On devices with an Intel Management Engine that are not fused using the |
Member
There was a problem hiding this comment.
This needs a note that this applies to all capsule updates before 2026 but future releases may be relieved from this requirement. Such releases will indicate so in their change logs and firmware update instructions.
Also worth addressing what happens if ME is not HAP-disabled so users know its safe to try: fwupd will attempt an update, but it will be rejected by the firmware.
|
|
||
| ## Firmware Update Prerequisites | ||
|
|
||
| ## Intel ME |
Member
There was a problem hiding this comment.
Should this be ### instead of ##?
| This output means the firmware version has changed to the expected one. | ||
| To manually verify this has really happened, refer to | ||
| [Checking The Current Firmware Version](#checking-the-current-firmware-version) | ||
| . |
Member
There was a problem hiding this comment.
Dot on its own line adds a space in front of it:
| `[FIRMWARE WARNING] Capsule Updates are only supported while Intel ME is in HAP mode!` | ||
|
|
||
| Make sure the Intel ME mode in Setup menu is `Disabled (HAP)`. Refer to the | ||
| [prerequisites section](#preparation--prerequisites) and try again. |
Member
There was a problem hiding this comment.
Suggested change
| [prerequisites section](#preparation--prerequisites) and try again. | |
| [prerequisites section](#firmware-update-prerequisites) and try again. |
| If you see any errors during the update, check the [Troubleshooting](../guides/capsule-update.md#troubleshooting) | ||
| section of the Capsule Update guide. | ||
| For instructions on how to perform updates using FWUPD and how to use the tool | ||
| in general, refer to the [Dasharo fwupd documentation](../kb/fwupd.md#updating-the-firmware) |
Member
There was a problem hiding this comment.
Suggested change
| in general, refer to the [Dasharo fwupd documentation](../kb/fwupd.md#updating-the-firmware) | |
| in general, refer to the [Dasharo fwupd documentation](../kb/fwupd.md#updating-the-firmware). |
Comment on lines
-44
to
-46
| !!! warning | ||
| Powering off instead of rebooting as instructed by fwupd will result in | ||
| aborting the update. |
Member
There was a problem hiding this comment.
I think is warning is missing from docs/kb/fwupd.md and it's worth having it there.
|
|
||
| If you see any errors during the update, check the [Troubleshooting](../../guides/capsule-update.md#troubleshooting) | ||
| section of the Capsule Update guide. | ||
| For instructions on how to use fwupd and update the firmware, follow the [Dasharo fwupd documentation](../../kb/fwupd.md#update-instructions) |
Member
There was a problem hiding this comment.
Suggested change
| For instructions on how to use fwupd and update the firmware, follow the [Dasharo fwupd documentation](../../kb/fwupd.md#update-instructions) | |
| For instructions on how to use fwupd and update the firmware, follow the [Dasharo fwupd documentation](../../kb/fwupd.md#update-instructions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: dsh-1121