common/power.c: Keep USB power on while system is shut off and on AC#76
Merged
filipleple merged 2 commits intomasterfrom Aug 29, 2025
Merged
common/power.c: Keep USB power on while system is shut off and on AC#76filipleple merged 2 commits intomasterfrom
filipleple merged 2 commits intomasterfrom
Conversation
Member
Author
This prevents suddenly removing power from the PD controller, which does not like such events if a USB-C device is connected. When that happens, the PD controller may glitch, causing Dasharo/dasharo-issues#1505 To avoid this, simply keep the USB power plane on while the system is on AC power. This has the side effect of enabling Always On USB always enabled when on AC power, but does not affect the function while on battery power only. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
filipleple
requested changes
Aug 29, 2025
Member
filipleple
left a comment
filipleple
left a comment
There was a problem hiding this comment.
Pls fix precommit, a typo got introduced in the previous PR on this issue here: https://github.com/Dasharo/ec/pull/73/files#diff-e349bcb69bec1ff6bb6ce1bd44797521246ea36281d682215e2ecae390835474R53
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Member
Author
filipleple
approved these changes
Aug 29, 2025
Member
filipleple
left a comment
filipleple
left a comment
There was a problem hiding this comment.
LGTM, will test on HW along with the coreboot PR and merge
Member
Author
|
Tested on V540TU with Wavlink UMD05 Pro Rev. E, issue no longer reproduces. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents suddenly removing power from the PD controller, which does not like such events if a USB-C device is connected. When that happens, the PD controller may glitch, causing
Dasharo/dasharo-issues#1505
To avoid this, simply keep the USB power plane on while the system is on AC power. This has the side effect of enabling Always On USB always enabled when on AC power, but does not affect the function while on battery power only.