🐛 [RUM-1092] Fix stack overflow in generateUUID#4240
Conversation
…) with iterative loop
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 8b1cef6 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b1cef6c3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ? // eslint-disable-next-line no-bitwise | ||
| (parseInt(placeholder, 10) ^ ((Math.random() * 16) >> (parseInt(placeholder, 10) / 4))).toString(16) | ||
| : `${1e7}-${1e3}-${4e3}-${8e3}-${1e11}`.replace(/[018]/g, generateUUID) | ||
| export function generateUUID(): string { |
There was a problem hiding this comment.
Preserve generateUUID call signature compatibility
generateUUID is re-exported as part of @datadog/browser-core (packages/core/src/index.ts:156), but this change narrows its TypeScript signature from generateUUID(placeholder?: string) to zero arguments only. That is a source-compatible break for any typed consumer currently passing an argument (including undefined), which will now fail with “Expected 0 arguments” even though runtime behavior still accepts extra args. For a bugfix commit, this API break is unexpected and should be avoided by keeping the previous optional parameter in the signature.
Useful? React with 👍 / 👎.
|
/to-staging |
|
View all feedbacks in Devflow UI.
Commit 8b1cef6c3f will soon be integrated into staging-09.
Commit 8b1cef6c3f has been merged into staging-09 in merge commit 2e6fee834f. Check out the triggered DDCI request. If you need to revert this integration, you can use the following command: |
Integrated commit sha: 8b1cef6 Co-authored-by: rgaignault <roman.gaignault@datadoghq.com>
No description provided.