🔥 remove internalAnalyticsSubdomain and INTAKE_SITE_FED_STAGING#4354
Open
BenoitZugmeyer wants to merge 2 commits intov7from
Open
🔥 remove internalAnalyticsSubdomain and INTAKE_SITE_FED_STAGING#4354BenoitZugmeyer wants to merge 2 commits intov7from
BenoitZugmeyer wants to merge 2 commits intov7from
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 12a3612 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
BeltranBulbarellaDD
approved these changes
Mar 17, 2026
Comment on lines
-41
to
-48
| it('should not start with ddsource for internal analytics mode', () => { | ||
| const url = createEndpointBuilder({ ...initConfiguration, internalAnalyticsSubdomain: 'foo' }, 'rum').build( | ||
| 'fetch', | ||
| DEFAULT_PAYLOAD | ||
| ) | ||
| expect(url).not.toContain('/rum?ddsource') | ||
| expect(url).toContain('ddsource=browser') | ||
| }) |
Collaborator
There was a problem hiding this comment.
I'm not sure why we were doing this (found RUMF-1464, but it's not very clear), but this does not seems to be replicated in web-ui.
Member
Author
There was a problem hiding this comment.
Good catch. I'll replicate in web-ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two internal SDK behaviors —
internalAnalyticsSubdomaininit option and theINTAKE_SITE_FED_STAGINGspecial-casing — were workarounds for routing data to Datadog-internal intake endpoints. These are now handled in web-ui using the standardproxyinitialization parameter, making them unnecessary.Changes
internalAnalyticsSubdomaininit option (modified intake host and reversed query parameter order for internal use)INTAKE_SITE_FED_STAGINGconstant and itshttp-intake.logs.dd0g-gov.comspecial-casing inbuildEndpointHostTest instructions
No user-visible behavior change. These were internal-only behaviors not exposed to customers.
Checklist