Skip to content

🔥 remove internalAnalyticsSubdomain and INTAKE_SITE_FED_STAGING#4354

Open
BenoitZugmeyer wants to merge 2 commits intov7from
benoit/remove-internal-options
Open

🔥 remove internalAnalyticsSubdomain and INTAKE_SITE_FED_STAGING#4354
BenoitZugmeyer wants to merge 2 commits intov7from
benoit/remove-internal-options

Conversation

@BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Mar 17, 2026

Motivation

Two internal SDK behaviors — internalAnalyticsSubdomain init option and the INTAKE_SITE_FED_STAGING special-casing — were workarounds for routing data to Datadog-internal intake endpoints. These are now handled in web-ui using the standard proxy initialization parameter, making them unnecessary.

Changes

  • Remove internalAnalyticsSubdomain init option (modified intake host and reversed query parameter order for internal use)
  • Remove INTAKE_SITE_FED_STAGING constant and its http-intake.logs.dd0g-gov.com special-casing in buildEndpointHost

Test instructions

No user-visible behavior change. These were internal-only behaviors not exposed to customers.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-official
Copy link

datadog-official bot commented Mar 17, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 74.48%
Overall Coverage: 77.25%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 12a3612 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@BenoitZugmeyer BenoitZugmeyer changed the base branch from main to v7 March 17, 2026 17:32
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Mar 17, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 170.95 KiB 170.77 KiB -184 B -0.11%
Rum Profiler 6.18 KiB 6.18 KiB 0 B 0.00%
Rum Recorder 27.48 KiB 27.48 KiB 0 B 0.00%
Logs 56.51 KiB 56.35 KiB -161 B -0.28%
Rum Slim 128.19 KiB 128.03 KiB -161 B -0.12%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0069 0.0049 -28.99%
RUM - add action 0.019 0.0161 -15.26%
RUM - add error 0.0167 0.0166 -0.60%
RUM - add timing 0.0033 0.0032 -3.03%
RUM - start view 0.0154 0.0137 -11.04%
RUM - start/stop session replay recording 0.001 0.0008 -20.00%
Logs - log message 0.0223 0.0175 -21.52%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 27.55 KiB 32.74 KiB +5.19 KiB
RUM - add action 51.99 KiB 57.61 KiB +5.62 KiB
RUM - add timing 26.39 KiB 34.49 KiB +8.09 KiB
RUM - add error 55.79 KiB 64.38 KiB +8.60 KiB
RUM - start/stop session replay recording 25.34 KiB 34.50 KiB +9.16 KiB
RUM - start view 462.57 KiB 469.11 KiB +6.53 KiB
Logs - log message 44.62 KiB 49.54 KiB +4.92 KiB

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review March 17, 2026 17:33
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 17, 2026 17:33
Comment on lines -41 to -48
it('should not start with ddsource for internal analytics mode', () => {
const url = createEndpointBuilder({ ...initConfiguration, internalAnalyticsSubdomain: 'foo' }, 'rum').build(
'fetch',
DEFAULT_PAYLOAD
)
expect(url).not.toContain('/rum?ddsource')
expect(url).toContain('ddsource=browser')
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we were doing this (found RUMF-1464, but it's not very clear), but this does not seems to be replicated in web-ui.

Image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll replicate in web-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants