Merged
Conversation
iunanua
force-pushed
the
igor/unix-socket-detection
branch
from
90a9c5f to
fdd21e4
Compare
| if custom_handle.is_none() { | ||
| let mut builder = worker::TelemetryWorkerBuilder::new( | ||
| config.trace_agent_url().to_string(), | ||
| let mut builder = worker::TelemetryWorkerBuilder::new_fetch_host( |
Collaborator
Author
There was a problem hiding this comment.
Cause it might be wrong since the beginning. We were initializing the builder with trace_agent_url as the host.
But TelemetryWorkerBuilder::new_fetch_host infers the host based on data from the real host (hostname, container id, etc) https://github.com/DataDog/libdatadog/blob/main/libdd-telemetry/src/lib.rs#L22
paullegranddc
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trace_agent_urlis empty and if user hasn't providedagent_hostnoragent_portand UDS is alive, use/var/run/datadog/apm.socketas agent_url and/var/run/datadog/dsd.socketas dogstatsd url.Extra
TelemetryWorkerBuilder could be using the wrong host.