chore: add CLAUDE.md symlink and compile skill#544
Open
Conversation
- Symlink CLAUDE.md -> AGENTS.md so Claude Code auto-loads the agent guide (formatting rules, build workflow) in every session without duplicating content. - Add a project-level `compile` skill that reuses a running Ubuntu 24 dev container when possible, otherwise starts one detached, then runs the DebTidy (clang + clang-tidy) build via `docker exec`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nsavoire
reviewed
Apr 27, 2026
| source ./setup_env.sh | ||
| MkBuildDir Deb | ||
| DebCMake ../ | ||
| make -j10 |
Collaborator
There was a problem hiding this comment.
nit: I like to use ninja instead of make (and it has the benefits of not having to specify a -jXX flag)
nsavoire
reviewed
Apr 27, 2026
| docker exec "$CID" bash -lc ' | ||
| set -euo pipefail | ||
| cd /app | ||
| export CC=clang CXX=clang++ |
Collaborator
There was a problem hiding this comment.
nit: would be nice to have DebTidyCMake setting correctly CC and CXX
nsavoire
previously approved these changes
Apr 27, 2026
r1viollet
force-pushed
the
r1viollet/claude-setup
branch
from
43e711c to
eca0c23
Compare
nsavoire
reviewed
Apr 28, 2026
| } | ||
|
|
||
| GetDirectoryExtention() { | ||
| echo "_${DDPROF_EXTENSION_CC}_${DDPROF_EXTENSION_OS}_${1}" |
Collaborator
There was a problem hiding this comment.
Ensure that MkBuildDir DebTidy uses a correct suffix:
Suggested change
| # $1: mode suffix (Rel, Debug, DebTidy, SanitizedDebug, ...) | |
| # DebTidy is clang-only by design — force the clang segment regardless of CC. | |
| local CC_SUFFIX=${DDPROF_EXTENSION_CC} | |
| if [[ "$1" == "DebTidy" ]]; then | |
| CC_SUFFIX=clang | |
| fi | |
| echo "_${CC_SUFFIX}_${DDPROF_EXTENSION_OS}_${1}" |
nsavoire
reviewed
Apr 28, 2026
| local VENDOR_EXTENSION=$(GetDirectoryExtention ${BUILD_TYPE}) | ||
| # shellcheck disable=SC2086 | ||
| cmake_cmd="cmake ${COMMON_OPT} -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DVENDOR_EXTENSION=${VENDOR_EXTENSION} $@" | ||
| cmake_cmd="cmake -GNinja ${COMMON_OPT} -DCMAKE_BUILD_TYPE=${BUILD_TYPE} -DVENDOR_EXTENSION=${VENDOR_EXTENSION} $@" |
Collaborator
There was a problem hiding this comment.
Examples in Agents.MD need to be adjusted to use ninja instead of make
nsavoire
reviewed
Apr 28, 2026
| On failure, extract the first compiler/clang-tidy errors: | ||
|
|
||
| ```bash | ||
| grep -E "error:" /tmp/ddprof_compile.log | head -20 |
Collaborator
There was a problem hiding this comment.
This seems fragile and probably misses some errors
nsavoire
reviewed
Apr 28, 2026
Comment on lines
+105
to
+108
| isn't blocked. **Do not pipe to `tee`** when backgrounding — `tee` swallows | ||
| the failing exit code from `ninja` and the build looks like it succeeded. If | ||
| you need the log on disk, redirect with `> /tmp/ddprof_compile.log 2>&1` | ||
| instead, or set `set -o pipefail` and check `${PIPESTATUS[0]}` explicitly. |
Collaborator
There was a problem hiding this comment.
This is confusing, it says don't pipe to tee, then says set pipefail AND check ${PIPESTATUS[0]}.
With pipefail (already set in the heredoc one block above) tee is fine and ${PIPESTATUS[0]} is redundant (it's an alternative to setting pipefail).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
compileskill that reuses a running Ubuntu 24 dev container when possible, otherwise starts one detached, then runs the DebTidy (clang + clang-tidy) build viadocker exec.Motivation
Ensure you can compile from a claude agent.
Additional Notes
NA
How to test the change?
Start claude, do a /compile