Repository navigation
feat: add BITSTATE_BYTECODE strategy for prefix-guarded scan patterns - #99
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=========================================
+ Coverage 83.1% 83.4% +0.2%
Complexity 1 1
=========================================
Files 134 135 +1
Lines 41223 42147 +924
Branches 5548 5605 +57
=========================================
+ Hits 34288 35166 +878
- Misses 5217 5227 +10
- Partials 1718 1754 +36
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Detects the ^(?:leadingWs(kw1|kw2|...)separatorWs)?mandatoryCharSet+(tail) AST shape and compiles it to straight-line bytecode instead of routing through the general BitState interpreter. Review fixes: decline when leadingWs/separator charsets overlap the mandatory charset (no give-back possible), require unbounded+greedy quantifiers throughout, correct extractDisjointKeywords javadoc, and guard against an empty keyword list.
jbachorik
force-pushed
the
feat/bitstate-bytecode-generator
branch
from
July 8, 2026 10:19
515c482 to
7db5913
Compare
…d branches Adds a compile-time ReggieMatcherBytecodeGenerator test for the case BITSTATE_BYTECODE dispatch arm (previously 0% patch coverage — only the runtime dispatch path was tested), plus PatternAnalyzer detector negative tests for each quantifier's greedy/max guard and the leadingWs-overlap branch, per the codecov coverage regression on PR #99.
jbachorik
marked this pull request as ready for review
July 8, 2026 10:44
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c69a83e02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
skipSeparator only stores separatorMin and emits an unbounded greedy
scan, so a bounded separator quantifier (e.g. \s{1,3}) let the
generated matcher over-consume past JDK's upper bound, diverging on
inputs where the separator run exceeds the bound.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
BITSTATE_BYTECODEmatching strategy:PatternAnalyzer.detectPrefixGuardedScanrecognizes the
^(?:leadingWs(kw1|kw2|...)separatorWs)?mandatoryCharSet+trailingWs*(tail)AST shape and
BitStateBytecodeGeneratorcompiles it to straight-line, non-backtracking JVMbytecode instead of routing through the general
BitStateinterpreter. Wired into both theruntime (
RuntimeCompiler) and compile-time (ReggieMatcherBytecodeGenerator) dispatch paths.Motivation
This pattern shape (an optional prefix keyword + separator, then a mandatory greedy scan and a
.*tail) is common enough in practice to warrant a dedicated fast path over the generalBitState interpreter.
Related Issue(s)
Change Type
Checklist
./gradlew build)Performance Impact
Not benchmarked in this PR.
Additional Notes
Detector-side hardening applied during review: decline when the leading-whitespace or separator
charset overlaps the mandatory charset (no give-back is possible without discarding the whole
prefix), require unbounded max and greedy quantifiers throughout the recognized shape, corrected
extractDisjointKeywords' javadoc to match the generator's actual sequential-comparisonimplementation, and guard against an empty keyword list.