Add size-benchmark crate with FFI coverage and CI integration#1920
Draft
Add size-benchmark crate with FFI coverage and CI integration#1920
Conversation
Adds a new `size-benchmark` crate with a build.rs that: - Scans all *-ffi/src/**/*.rs files using syn - Finds all #[no_mangle] pub extern "C" fn signatures - Generates $OUT_DIR/calls.rs with exercise_all() For accessible public-module functions: called via qualified Rust path with zero/null args. For private-module functions: referenced via address-of extern "C" stubs to force linker inclusion. Adds ddog_ddsketch_dummy_size_bench() to libdd-ddsketch-ffi for verification. Release binary: ~10MB (LTO + opt-level=s). Coverage: 20 functions called (with args), 249 referenced (address-only)
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
…ith github-script
Contributor
|
Contributor
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 64b1f60 | Docs | Datadog PR Page | Give us feedback! |
… with workspace C libs
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 71.75% 71.69% -0.06%
==========================================
Files 434 435 +1
Lines 69954 69955 +1
==========================================
- Hits 50192 50154 -38
- Misses 19762 19801 +39
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with another way of measuring the final binary size with a auto-generated binary that has an array of pointers of all functions of public *-ffi functions so that they are included at link time.
The binary is optimized it with lots of LTO and other binary size optimisation tricks so that there is less noise of things that would go away for users.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.