Skip to content

[ruby] Enable FFE flag evaluation metrics tests [ruby@sameerank/FFL-1945/add-flag-eval-metrics] #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameerank wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Open

[ruby] Enable FFE flag evaluation metrics tests [ruby@sameerank/FFL-1945/add-flag-eval-metrics] #6781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26cb77f
[ruby] Enable FFE flag evaluation metrics tests for rails72
sameerank Apr 21, 2026
10bb760
Remove unnecessary comment from Gemfile
sameerank Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion manifests/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,10 @@ manifest:
- weblog_declaration:
"*": irrelevant
rails72: v2.23.0-dev
tests/ffe/test_flag_eval_metrics.py: missing_feature
tests/ffe/test_flag_eval_metrics.py:
- weblog_declaration:
"*": irrelevant
rails72: v2.31.0-dev
tests/integration_frameworks/llm/anthropic/test_anthropic_llmobs.py::TestAnthropicLlmObsMessages::test_create_error: bug (MLOB-1234)
tests/integrations/crossed_integrations/test_kafka.py::Test_Kafka:
- weblog_declaration:
Expand Down
5 changes: 4 additions & 1 deletion utils/build/docker/ruby/rails72/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@ gem 'bootsnap', require: false
gem 'ruby-kafka', '~> 1.5.0'
gem 'opentelemetry-api', '~> 1.5.0'
gem 'opentelemetry-sdk', '~> 1.8.0'
gem 'opentelemetry-common', '>= 0.23.0'
gem 'opentelemetry-metrics-sdk', '>= 0.8'
gem 'opentelemetry-exporter-otlp-metrics', '>= 0.6'
# AppSec related dependencies
gem 'devise', '~> 4.9'
gem 'faraday', '~> 2.13.0'
gem 'faraday-follow_redirects', '~> 0.3'
# FFE related dependencies
gem 'openfeature-sdk', '~> 0.4'
gem 'openfeature-sdk', '~> 0.5' # v0.5.1+ required for provider hooks support
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Constrain openfeature-sdk to 0.5.1-compatible versions

openfeature-sdk is declared as ~> 0.5, but this range also allows 0.6.x (and newer <1.0) releases. Since this change explicitly depends on provider hooks support from 0.5.1+, allowing 0.6.x can pull in a different API line during image builds and break the Datadog OpenFeature integration used by the FFE metrics tests. Pin this to the intended compatibility window (for example ~> 0.5.1 or >= 0.5.1, < 0.6).

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

@sameerank sameerank Apr 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the upper bound that was previously in place (up to < 1.0), and the provided justification for limiting the minor version to < 0.6 contradicts our passing tests which use the latest available openfeature-sdk 0.6.5 version

https://github.com/DataDog/system-tests/actions/runs/24794277678/job/72560160287

Look for Using openfeature-sdk 0.6.5 in the "Build weblog" step during the bundle install output.


group :development do
gem 'pry-byebug'
Expand Down
12 changes: 12 additions & 0 deletions utils/build/docker/ruby/rails72/app/controllers/internal_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ def flush
worker.send(:send_events, *worker.dequeue)
end

# Flush OTel metrics
begin
if defined?(::OpenTelemetry) && defined?(::OpenTelemetry::SDK::Metrics::MeterProvider)
meter_provider = ::OpenTelemetry.meter_provider
if meter_provider.is_a?(::OpenTelemetry::SDK::Metrics::MeterProvider)
Copy link
Copy Markdown
Member

@Strech Strech Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal of this check?

meter_provider.force_flush
end
end
rescue => e
Rails.logger.warn("Failed to flush OTel metrics: #{e.class}: #{e}")
Comment on lines +51 to +52
Copy link
Copy Markdown
Member

@Strech Strech Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to surface exception as it will be better to see, this is testing app and suppose to highlight issues.

end

render plain: 'OK'
end
end
Loading