Skip to content

[nodejs@maximo/otlp-runtime-metrics-poc] Enable OTLP runtime metrics test for Node.js#6798

Draft
link04 wants to merge 3 commits intomainfrom
maximo/otlp-runtime-metrics-enables-test-nodejs
Draft

[nodejs@maximo/otlp-runtime-metrics-poc] Enable OTLP runtime metrics test for Node.js#6798
link04 wants to merge 3 commits intomainfrom
maximo/otlp-runtime-metrics-enables-test-nodejs

Conversation

@link04
Copy link
Copy Markdown
Contributor

@link04 link04 commented Apr 22, 2026

Summary

  • Enable Test_OtlpRuntimeMetrics for Node.js v6.0.0 in the nodejs manifest
  • Depends on dd-trace-js#7869 being merged first
  • Depends on system-tests#6715 being merged first (adds the scenario and test)

Test plan

  • dd-trace-js#7869 merged
  • system-tests#6715 merged
  • CI green with Node.js OTLP runtime metrics test passing

🤖 Generated with Claude Code

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/test_otlp_runtime_metrics.py                                      @DataDog/system-tests-core
.github/workflows/run-end-to-end.yml                                    @DataDog/system-tests-core
manifests/cpp.yml                                                       @DataDog/dd-trace-cpp
manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/nodejs.yml                                                    @DataDog/dd-trace-js
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/scripts/ci_orchestrators/workflow_data.py                         @DataDog/system-tests-core

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 22, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 41 Tests failed

tests.ai_guard.test_ai_guard_sdk.Test_ClientIPTagsCollected.test_client_ip_tags[express4] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: assert 'network.client.ip' in {'_dd.code_origin.frames.0.column': '5', '_dd.code_origin.frames.0.file': '/usr/app/app.js', '_dd.code_origin.frames.0.line': '757', '_dd.code_origin.frames.0.method': '<anonymous>', ...}

self = <tests.ai_guard.test_ai_guard_sdk.Test_ClientIPTagsCollected object at 0x7f90ebb62fc0>

    def test_client_ip_tags(self):
        """Test AI Guard collects client IP tags on the local root span with AppSec disabled."""
        assert self.r.status_code == 200
    
        spans = [span for _, _, span in interfaces.library.get_spans(request=self.r, full_trace=True)]
        assert any(span.get("resource") == "ai_guard" for span in spans), "No ai_guard span found in the trace"
...
tests.ai_guard.test_ai_guard_sdk.Test_Tag_Probabilities.test_tag_probabilities[express4] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: 'tag_probs' not found in '{'action': 'DENY', 'reason': 'Rule matches: destructive-tool-call', 'tags': ['destructive-tool-call'], 'sds': []}'
assert 'tag_probs' in {'action': 'DENY', 'reason': 'Rule matches: destructive-tool-call', 'sds': [], 'tags': ['destructive-tool-call']}

self = <tests.ai_guard.test_ai_guard_sdk.Test_Tag_Probabilities object at 0x7f90ebb63410>

    def test_tag_probabilities(self):
        """Test AI Guard returns and stores tag probabilities.
        Verifies the SDK response exposes tag probabilities and the ai_guard meta struct keeps the
        same probability map received from the AI Guard REST API.
        """
...
tests.appsec.waf.test_blocking_security_response_id.Test_SecurityResponseId_Custom_Redirect.test_security_response_id_in_redirect_url[express4] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: security_response_id is not a valid UUIDv4: [security_response_id]
assert False
 +  where False = is_valid_uuid4('[security_response_id]')

self = <tests.appsec.waf.test_blocking_security_response_id.Test_SecurityResponseId_Custom_Redirect object at 0x7f7a141b8320>

    def test_security_response_id_in_redirect_url(self):
        """Verify security_response_id is present in redirect URL and is a valid UUIDv4"""
        assert self.r_redirect.status_code == 301, f"Expected 301, got {self.r_redirect.status_code}"
    
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cbb05d3 | Docs | Datadog PR Page | Give us feedback!

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@link04 link04 force-pushed the maximo/otlp-runtime-metrics-enables-test-nodejs branch from b0f80dd to 3fa9c5a Compare April 22, 2026 19:26
@link04 link04 added javascript Pull requests that update Javascript code run-all-scenarios labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code run-all-scenarios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant