This repository was archived by the owner on May 7, 2026. It is now read-only.
chore: migrate to policy/v1 - #1
Open
yz89122 wants to merge 1 commit into
Open
Conversation
yz89122
marked this pull request as draft
October 2, 2023 09:11
yz89122
marked this pull request as ready for review
October 2, 2023 09:21
taco-lin
approved these changes
Oct 2, 2023
tommy351
reviewed
Oct 4, 2023
| selector: | ||
| matchLabels: | ||
| {{- include "scylla-manager.controllerSelectorLabels" . | nindent 6 }} | ||
| { { - include "scylla-manager.controllerSelectorLabels" . | nindent 6 } } |
Member
There was a problem hiding this comment.
Suggested change
| { { - include "scylla-manager.controllerSelectorLabels" . | nindent 6 } } | |
| {{ - include "scylla-manager.controllerSelectorLabels" . | nindent 6 }} |
Author
There was a problem hiding this comment.
Thanks, I should disable my formatter
yckao
approved these changes
Oct 4, 2023
benjamin99
approved these changes
Oct 5, 2023
yz89122
force-pushed
the
chore/migrate-to-policy-v1
branch
from
October 5, 2023 09:32
344b40c to
b09453b
Compare
yz89122
force-pushed
the
chore/migrate-to-policy-v1
branch
from
October 5, 2023 09:33
b09453b to
cf635e2
Compare
tommy351
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate to
policy/v1.Related Docs
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125