Conversation
- Install Unity3D NuGet package to simplify Unity assembly dependencies
- Install Unity3D NuGet package to simplify Unity assembly dependencies
- Add Unity editor path parameter - Handle *.tmp files existence before deleting - Better log messages
They are redundant since they are generated when compiling the 2 projects (DOTween and DOTweenEditor).
- Fix texture loading in both asset and package mode - Only allow manipulating asmdef on asset mode
- Add more Unity versions - Compile DOTween_LooseScripts project where possible (< 2019.2)
- Use original 5.6.7f1 reference
|
Such a huge work ! Thanks for that :) |
|
I would also appreciate if this could be integrated, because this makes it much easier to provide packages which depend on dotween. |
|
@Demigiant please take a look |
|
@Demigiant please can we have some traction on this? thanks!!! |
|
@Demigiant I am in the process of migrating all my projects to UPM. As DOTween is a great tweening engine and I would like to continue using it, I would be happy if this pull request is merged. |
In the meantime, you may be interested in https://github.com/jeffreylanters/unity-tweens. I tried it and it is very similar, but has updates and UPM |
|
Is there any news on whether this will be merged anytime soon? |
|
See #251 (comment) for latest update from @Demigiant |
|
Would love for this to be possible |
@Demigiant Please check everything to see if it is working as it should. I have done checks but you know DOTween better than I do.
I have tried to order this PR in several commits and I have changed what is strictly necessary in *.cs files in order not to complicate this PR more. Once this PR is merged, other changes can be made.
I have developed more functionalities:
Package
When we merge this PR, we should be able to install the package as follows temporarily until it is published in OpenUPM:
"com.demigiant.dotween": "https://github.com/Demigiant/dotween.git?path=/Package#v1.2.632-upm"
DOTween and DOTweenEditor Projects
Asset vs Package
CI Workflow
You can set it as a check when creating PRs so that they must be validated with this worflow in order to be merged.
Other
Edited (25/07/2022):
Added the following:
In general I see that the repository is a bit disorganized with many files that in theory should be in one place but then they are not (references to DOTween Pro code) and it complicates everything a lot... I think you should have divided the repositories in 2 (free and pro) because without this PR nobody can build anything without spending time to remove references to DOTween Pro and it's quite a mess. As far as possible I'm helping to make at least the free part buildable by anyone and above all, through the workflow.