Skip to content

fix(graph-ui): clear ADR content on delete#985

Open
ShiroKSH wants to merge 1 commit into
DeusData:mainfrom
ShiroKSH:agent/fix-adr-delete
Open

fix(graph-ui): clear ADR content on delete#985
ShiroKSH wants to merge 1 commit into
DeusData:mainfrom
ShiroKSH:agent/fix-adr-delete

Conversation

@ShiroKSH

@ShiroKSH ShiroKSH commented Jul 9, 2026

Copy link
Copy Markdown

Summary

Fixes ADR deletion in the graph UI. The delete action cleared React state and then saved through the stale state value, so the old ADR content could be posted back instead of an empty body.

Changes

  • Allows the ADR save helper to receive the content that should be posted.
  • Sends an explicit empty ADR body from the delete action.
  • Wraps the normal save click handler so React mouse events are not treated as content.
  • Adds a regression test for deleting an existing ADR.

Validation

  • npm test -- --run src/components/StatsTab.test.tsx
  • npm test
  • npm run build
  • git diff --check

Signed-off-by: ShiroKSH <kushidashiro@gmail.com>
@DeusData DeusData added bug Something isn't working ux/behavior Display bugs, docs, adoption UX priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Jul 10, 2026
@DeusData DeusData added this to the 0.9.1-rc milestone Jul 10, 2026
@DeusData

Copy link
Copy Markdown
Owner

Thanks for the graph UI fix. I have triaged this into 0.9.1-rc as a normal-priority UX/behavior bug fix. Review focus will be the explicit empty delete body and making sure the UI event handling stays consistent with the ADR endpoints.

@ShiroKSH ShiroKSH marked this pull request as ready for review July 10, 2026 19:25
@ShiroKSH ShiroKSH requested a review from DeusData as a code owner July 10, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority/normal Standard review queue; useful PR with ordinary maintainer urgency. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants