test(mcp): regression guard for relative repo_path canonicalization (#794)#987
Merged
Conversation
On v0.8.1, index_repository with repo_path "." flowed the literal dot through everything derived from the path: the project was named "root", the projects table stored root_path="." verbatim, the post-dump integrity check flagged bad_root_path and auto-deleted the entire DB — while the response still reported status "indexed" with full node counts. Verified fixed on current main (the path is canonicalized before derivation: correct project name, absolute root_path, persistent and queryable DB). The guard indexes with repo_path "." from inside the repo and asserts the three things the old failure mode broke: path-derived project name (never "root"), absolute canonical root_path in the projects table, and a DB that survives the run and answers queries. Closes #794 Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
glibc _FORTIFY_SOURCE aborts realpath() into a sub-PATH_MAX buffer regardless of the actual path length, and Windows has no realpath at all. Size the buffers at PATH_MAX and skip the guard on Windows (the #794 canonicalization logic is platform-independent; the four Unix legs carry it). Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification of #794 (relative
repo_path"." corrupts + auto-deletes the project DB on every run, v0.8.1) against current main: already fixed — the path is canonicalized before anything derives from it. Reproduced the reporter's exact flow (cd repo && cli index_repository '{"repo_path": "."}'): project name is path-derived (not "root"), the projects table stores the absolute canonical root_path, the DB persists, and queries work.This PR lands the regression guard: index "." from inside the repo, assert the three things the old failure mode broke (path-derived name, absolute stored root_path == realpath, surviving + queryable DB). If the canonicalization ever regresses, the guard fails at the auto-clean step (missing DB) or the root_path assertion.
Net diff: tests only, +100 lines.
Closes #794