Add range value buttons to RangeSelector - Overview demo#212
Open
jvlimos wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card: https://github.com/DevExpress/asptribe/issues/788
Teams discussion: https://teams.microsoft.com/l/message/19:9c6731721afa4447b78718f9e946c2a6@thread.skype/1773836657483?tenantId=e4d60396-9352-4ae8-b84c-e69244584fa4&groupId=a7f26f88-ba0d-4d92-b58b-d5e29b6ba2d0&parentMessageId=1773836657483&teamName=ASP.NET&channelName=Examples&createdTime=1773836657483
Regarding the code, I had to use separate variables for the RangeSelector's SelectedRangeStartValue and SelectedRangeEndValue properties. If I use the same
StartValueandEndValuevariables, dragging the selector range causes an endless loop, which seems like a race condition. Also using two-way binding for those properties (without handling ValueChanged event) causes such issues.