Open
Conversation
Comment on lines
+1921
to
+1944
| // erase extensions not supported by llvm | ||
| { | ||
| core::vector<const char*> llvmUnsupportedExtensions = { | ||
| "VK_NV_shader_image_footprint", | ||
| "VK_KHR_fragment_shader_barycentric", | ||
| "VK_EXT_conservative_rasterization", | ||
| "VK_KHR_external_memory_win32", | ||
| "VK_KHR_shader_subgroup_uniform_control_flow", | ||
| "VK_EXT_pci_bus_info", | ||
| "VK_KHR_external_fence_win32", | ||
| "VK_KHR_external_semaphore_win32", | ||
| "VK_KHR_win32_keyed_mutex", | ||
| "VK_EXT_discard_rectangles" | ||
| "VK_NV_compute_shader_derivatives", | ||
| "VK_NV_shader_sm_builtins" | ||
| }; | ||
|
|
||
| for (const char* extension : llvmUnsupportedExtensions) | ||
| { | ||
| auto it = std::find_if(extensionStrings.begin(), extensionStrings.end(), [extension](const char* s) { return std::strcmp(s, extension) == 0; }); | ||
| if(it != extensionStrings.end()) | ||
| extensionStrings.erase(it); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
this can get removed, we achieve much better with Vulkan Configurator & Profile Layer
Comment on lines
810
to
+811
| "name": "subgroupOpsShaderStages", | ||
| "value": "asset::IShader::E_SHADER_STAGE::ESS_COMPUTE | asset::IShader::E_SHADER_STAGE::ESS_ALL_GRAPHICS" | ||
| "value": "asset::IShader::E_SHADER_STAGE::ESS_UNKNOWN" |
Member
Author
There was a problem hiding this comment.
what does llvm-pipe report here ?
Comment on lines
1112
to
+1113
| "name": "supportedDepthResolveModes", | ||
| "value": "RESOLVE_MODE_FLAGS::SAMPLE_ZERO_BIT | RESOLVE_MODE_FLAGS::MIN_BIT | RESOLVE_MODE_FLAGS::MAX_BIT" | ||
| "value": "RESOLVE_MODE_FLAGS::SAMPLE_ZERO_BIT" |
Member
Author
There was a problem hiding this comment.
if we intend to downgrade Nabla (by merging this PR) then we need to neatly handle this in renderpass creation
Comment on lines
+1895
to
+1897
| // remove inheritedQueries since llvmpipe doesn't support it | ||
| vk_deviceFeatures2.features.inheritedQueries = VK_FALSE; | ||
| //vk_deviceFeatures2.features = VkPhysicalDeviceFeatures{}; |
Member
Author
There was a problem hiding this comment.
if we intend to downgrade Nabla permamently, then we need to bring inheritedQueries into the Nabla limits JSON
then check in commandbuffers that when someone is recording an execute secondary commandbuffers command in a primary cmdbuf, no queries are open unless inheritedQueries limit is true
…into llvmpipe_device
…into llvmpipe_device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: