Add "show on hover" mode for navbar visibility#13
Draft
Conversation
…tion - Change SHOW_FRAME setting from boolean to select with 'always', 'hover', 'never' options - Add before-mouse-event listener in ViewPropagator for mouse enter/leave detection - Implement navbar show/hide animation using DeltaMove library in FrameService - Register before-mouse-event on navbar's webContents for hover tracking - Add backward compatibility for legacy boolean SHOW_FRAME values - Update all locale files (en, de, es, fr, it, pt-BR, pt-PT, ru) with new strings - Update preferences Settings UI from bool to select input Agent-Logs-Url: https://github.com/ECRomaneli/Handbook/sessions/51eed423-f5af-498b-83f6-556371f2839d Co-authored-by: ECRomaneli <10746786+ECRomaneli@users.noreply.github.com>
…ethod Address code review feedback: - Extract NAVBAR_HIDE_DELAY_MS and NAVBAR_ANIMATION_DURATION_MS constants - Add clearHoverTimeout() helper method Agent-Logs-Url: https://github.com/ECRomaneli/Handbook/sessions/51eed423-f5af-498b-83f6-556371f2839d Co-authored-by: ECRomaneli <10746786+ECRomaneli@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update showFrame functionality to show navbar on hover
Add "show on hover" mode for navbar visibility
Apr 17, 2026
ECRomaneli
requested changes
Apr 17, 2026
Owner
ECRomaneli
left a comment
ECRomaneli
left a comment
There was a problem hiding this comment.
The navbar is not being shown when the mouseenter
The before-mouse-event in Electron does not reliably fire mouseEnter. Use mouseMove to detect cursor presence (matching electron-draggable's approach) with existing navbarVisible guard preventing repeated triggers. Agent-Logs-Url: https://github.com/ECRomaneli/Handbook/sessions/b4344d7d-0123-4b22-a772-4bd0c807f359 Co-authored-by: ECRomaneli <10746786+ECRomaneli@users.noreply.github.com>
Author
Fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delta-movedependencyConstants.ts- default SHOW_FRAME to'always', support'hover'and'never'ViewPropagator.ts- registerbefore-mouse-eventfor mouse enter/leave detectionFrameService.ts- handle'hover'mode with DeltaMove animationsSettings.js(preferences UI) - change from bool to select with backward compatmouseMoveinstead ofmouseEnterfor hover detection (mouseEnter not reliably fired by before-mouse-event)