Skip to content

Only load ReFrame programming env in find_modules if it is not yet in module cache - #345

Merged
laraPPr merged 1 commit into
mainfrom
optimize_find_modules
Jul 10, 2026
Merged

Only load ReFrame programming env in find_modules if it is not yet in module cache#345
laraPPr merged 1 commit into
mainfrom
optimize_find_modules

Conversation

@casparvl

Copy link
Copy Markdown
Collaborator

Small optimization: we don't need to load the ReFrame programming environment if the entry is already in the module cache

…ironment if the entry is already in the module cache

@laraPPr laraPPr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
laraPPr merged commit 3f76d4e into main Jul 10, 2026
30 checks passed
@casparvl

Copy link
Copy Markdown
Collaborator Author

For posterity: I tested using time reframe -c test-suite/eessi/testsuite/tests/apps/walberla/walberla.py -c test-suite/eessi/testsuite/tests/apps/MetalWalls.py --list and this PR reduced the runtime from 45 to 35 seconds. That's as expected, as on this cluster I saw the loading of the environment take 10s for every test class. In this case, it has to load them for walberla (first test class) since there's no module cache yet. But you save on it the second time around, thus saving 10 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants