Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings of the Opus encoder can be configured by the opus_encoder_ctl() function. As it uses variadic parameters, there was so far no support in opus_dart. As ffigen now supports variadics, I used it to generate a wrapper for opus_encoder_ctl().
This operation was done outside opus_dart. ffi_tool in the tool directory does not work anymore. I kindly ask you to decide if you want to delete the tool directory.
Also ffi_tool is still mentioned in README.md. I just added the documentation of encoder CTL at the end. Please also decide about removing references to ffi_tool.
Markus