Skip to content

대시보드 코인 추천 디자인 변경 #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jihyeonjjang merged 6 commits into from
Nov 4, 2025
Merged

대시보드 코인 추천 디자인 변경 #670

jihyeonjjang merged 6 commits into from
Nov 4, 2025

Conversation

@jihyeonjjang
Copy link
Member

@jihyeonjjang jihyeonjjang commented Nov 3, 2025 •
edited by leekangho0
Loading

#️⃣ 연관된 이슈

ex) <#1377914257735421952>, <#1377914203255607316>

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 코인 추천 디자인 변경
    • 레이아웃 변경
    • 라인 차트 추가
    • 추천 이유 보여주는 sheet 추가
      • HIG에 따라 한 번에 하나의 시트만 표시되도록 함
        • '더 자세히 보러가기'를 누르면 열려있는 sheet는 닫히고, 차트를 보여주는 sheet가 열리게 됨

스크린샷 (선택)

image image image

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@jihyeonjjang jihyeonjjang requested a review from a team November 3, 2025 07:02
@jihyeonjjang jihyeonjjang self-assigned this Nov 3, 2025
@jihyeonjjang jihyeonjjang added the Feature 기능 관련 작업 label Nov 3, 2025
@jihyeonjjang jihyeonjjang linked an issue Nov 3, 2025 that may be closed by this pull request
추천 코인 디자인 변경 #645
Closed
kanghun1121
kanghun1121 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@kanghun1121 kanghun1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다👍

@leekangho0 leekangho0 requested a review from a team November 3, 2025 07:50
@jihyeonjjang jihyeonjjang force-pushed the design/coin-recommend-jh branch from 9af1454 to 7b1fe90 Compare November 4, 2025 02:06
@jihyeonjjang
fix: sheet가 중첩되어 열리지 않도록 수정
ef19861 
- HIG 권장사항에 따라 한 번에 하나의 시트만 표시되도록 변경하여, 모달 전환 시 사용자가 위치를 혼동하지 않도록 함.
@jihyeonjjang jihyeonjjang merged commit 447d7e8 into dev Nov 4, 2025
1 check passed
@jihyeonjjang jihyeonjjang deleted the design/coin-recommend-jh branch November 4, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kanghun1121 kanghun1121 kanghun1121 approved these changes

Assignees

@jihyeonjjang jihyeonjjang

Labels

Feature 기능 관련 작업

Projects

None yet

Milestone

배포 이후 수정 사항

Development

Successfully merging this pull request may close these issues.

[UIReport] HIG 모달 중첩 안티패턴 추천 코인 디자인 변경

3 participants

@jihyeonjjang @kanghun1121