Add support for specifying CA cert#189
Open
alexg-axis wants to merge 4 commits into
Open
Conversation
EdJoPaTo
reviewed
May 23, 2025
EdJoPaTo
left a comment
EdJoPaTo
left a comment
Owner
There was a problem hiding this comment.
Thank you for providing a PR for this!
I have some variable naming / argument naming thoughts to simplify understanding the args / code. But other than that it looks good!
|
|
||
| /// Path to the TLS CA certificate file. | ||
| /// | ||
| /// Used together with --client-cert, --client-key to enable TLS client |
Owner
There was a problem hiding this comment.
I think, requires can be used here then? When it’s used, the others have to be used too?
Keep them similar in different places. _path is superfluous as their type is already &Path.
As there are multiple different certificates handled now its harder to figure out which certificate created an error.
Conflicts: src/cli.rs src/mqtt/connect.rs src/mqtt/encryption.rs
Owner
|
Following https://test.mosquitto.org/ssl/ ends up with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #188