WirelessChannelSimulation: add HighReliableSimulation task - #15
Conversation
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, "HighReliableSimulation," within the "WirelessChannelSimulation" domain. The task focuses on implementing an efficient importance sampler for estimating Bit Error Rate (BER) in a specific wireless communication scenario. It includes detailed documentation, a baseline solution, and an evaluation script. The PR also adds an 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 在 "WirelessChannelSimulation" 领域内引入了一个新的基准测试任务 "HighReliableSimulation"。该任务专注于实现一种高效的重要性采样器,用于估计特定无线通信场景中的误码率 (BER)。它包括详细的文档、一个基线解决方案和一个评估脚本。此外,PR 还添加了一个 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new WirelessChannelSimulation/HighReliableSimulation benchmark task focused on variance-controlled importance sampling for ultra-low decoder error-rate estimation, and wires it into frontier_eval for execution via the task registry.
Changes:
- Added the
HighReliableSimulationbenchmark package (runtime, evaluator, baseline, calibration snapshot, and docs). - Registered a new
frontier_evaltask (high_reliable_simulation) and added a Hydra task config. - Vendored/added a
reliable_sim/implementation and supporting libs/scripts used as source material for the benchmark.
Reviewed changes
Copilot reviewed 43 out of 48 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| reliable_sim/run_experiment.py | Adds a CLI runner for ReliableSim experiments (currently imports missing test_general). |
| reliable_sim/plot_results.py | Adds JSON merging + plotting utilities (currently hardcoded __main__ demo path). |
| reliable_sim/plot_general.py | Adds general log parsing/plotting utilities (currently imports missing test_general). |
| reliable_sim/libs/hamming_matrix_6.csv | Adds precomputed Hamming matrices (r=6). |
| reliable_sim/libs/hamming_matrix_5.csv | Adds precomputed Hamming matrices (r=5). |
| reliable_sim/libs/hamming_matrix_4.csv | Adds precomputed Hamming matrices (r=4). |
| reliable_sim/libs/hamming_matrix_3.csv | Adds precomputed Hamming matrices (r=3). |
| reliable_sim/libs/hamming_matrix_2.csv | Adds precomputed Hamming matrices (r=2). |
| reliable_sim/libs/ORB_noise_lib_n7_max25_vec.json | Adds ORBGRAND noise pattern library for n=7. |
| reliable_sim/hamming_simulation.py | Adds a standalone (7,4) Hamming simulation prototype. |
| reliable_sim/find_snr.py | Adds a sigma/SNR exploration script (currently contains machine-specific sys.path). |
| reliable_sim/distance_calculator.py | Adds optimized sparse distance utilities (incl. permuted variants). |
| reliable_sim/decoder_analysis.py | Adds decoder-analysis helpers for “triple” noise patterns. |
| reliable_sim/code_linear.py | Adds linear-code base + HammingCode implementation + variance-controlled simulation. |
| reliable_sim/chase.py | Adds a Chase decoder implementation (current single-vector path appears broken). |
| reliable_sim/SGRAND.py | Adds GRAND / SGRAND decoder implementations. |
| reliable_sim/RM.py | Adds Reed–Muller code implementation. |
| reliable_sim/ORBGRAND.py | Adds ORBGRAND decoder implementation incl. noise-library generation/loading. |
| reliable_sim/README.md | Documents ReliableSim features and usage. |
| reliable_sim/CLAUDE.md | Adds agent guidance for working with this repo’s ReliableSim code. |
| frontier_eval/tasks/wireless_channel_simulation/task.py | Adds HighReliableSimulationTask that locates init program + evaluator. |
| frontier_eval/tasks/wireless_channel_simulation/init.py | Exposes HighReliableSimulationTask from the package. |
| frontier_eval/registry_tasks.py | Registers high_reliable_simulation task in the task registry. |
| frontier_eval/conf/task/high_reliable_simulation.yaml | Adds Hydra config entry for the new task. |
| benchmarks/WirelessChannelSimulation/README.md | Adds domain-level background and references for rare-event BER estimation. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/scripts/init.py | Provides initial submission program (MySampler) for the task. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/scripts/calibrate_sigma.py | Adds calibration utility for sigma / r0 / t0 under variance control. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/runtime/sampler.py | Vendors minimal sampler runtime (Naive + Bessel). |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/runtime/code_linear.py | Vendors minimal code runtime (Hamming + variance-controlled simulate). |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/runtime/chase.py | Vendors minimal Chase decoder runtime used by evaluator. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/runtime/init.py | Declares vendored runtime package. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/references/README.md | Documents included reference material. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/eval/evaluator.py | Implements the in-process evaluator and scoring metrics/constants. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/calibration_final.json | Stores the calibration snapshot for frozen evaluator constants. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/baseline/solution.py | Adds a baseline MySampler solution (BesselSampler). |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/USAGE.md | Provides detailed local usage + submission interface guidance. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/Task.md | Defines the task model, protocol, scoring, and frozen constants. |
| benchmarks/WirelessChannelSimulation/HighReliableSimulation/README.md | Task-level navigation + quickstart. |
| AGENTS.md | Adds repository-wide guidance for creating new ReliableSim-based tasks. |
| .gitignore | Ignores .ralph-tui/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import numpy as np | ||
| sys.path.append('/Users/haohan/workspace/Frontier-Engineering/reliable_sim') | ||
|
|
||
| from code_linear import HammingCode | ||
| from sampler import NaiveSampler |
There was a problem hiding this comment.
这里把本地绝对路径写死进 sys.path.append('/Users/haohan/...'),会导致在其他机器/CI 上不可运行。建议移除该行,改用相对路径(基于 __file__ / repo root)或把 reliable_sim 做成可安装包后通过正常的 import 路径加载。
| cand_rel[:,err_pos] *= (1-2*self.error_patterns) | ||
|
|
||
| candidates = hard_decision * np.ones((self.error_patterns.shape[0], self.n)) # (n_noise, n) | ||
| candidates[:, err_pos] = (hard_decision[err_pos] + self.error_patterns) % 2 # (n_noise, n) | ||
|
|
There was a problem hiding this comment.
decode_vector 中对 self.error_patterns 的使用会触发形状不匹配:cand_rel[:, err_pos] 形状是 (num_patterns, t),但 self.error_patterns 是 (num_patterns, n),导致广播失败/结果错误。同样 candidates[:, err_pos] = (hard_decision[err_pos] + self.error_patterns) % 2 也不匹配。建议让 error_patterns 仅保存 t 位模式(形状 (num_patterns, t)),或在这里对模式做 [:, :self.errs] 并确保其与 err_pos 对齐(或复用 batch decode 的“先按可靠性排序再加噪声再反排序”的实现)。
| def _generate_matrix(self): | ||
| """生成汉明码的生成矩阵G和校验矩阵H""" | ||
| try: | ||
| name = f'libs/hamming_matrix_{self.r}.csv' | ||
| M = np.loadtxt(name, delimiter=',', dtype=int) | ||
| # delta = M[:self.k, :self.r] | ||
| # G = np.hstack((np.eye(self.k, dtype=int), delta)) | ||
| # H = np.hstack((delta.T, np.eye(self.r, dtype=int))) | ||
| G = M[:self.k, :] | ||
| H = M[self.k:, :] | ||
|
|
||
| # build hash table for H | ||
| sums = 2**np.arange(self.r) @ H | ||
| self.H_hash = np.zeros(2**self.r, dtype=int) | ||
| for i, s in enumerate(sums): | ||
| self.H_hash[s] = i | ||
| return G, H | ||
| except ImportError: | ||
| print("警告: 未预备汉明码生成和校验矩阵,使用自定义实现") | ||
| # 使用我们自己的实现作为后备 | ||
| # return self._generate_matrix_custom() | ||
| return self._generate_hamming_matrices() | ||
|
|
There was a problem hiding this comment.
_generate_matrix 这里用 except ImportError 来捕获矩阵文件加载失败不正确:np.loadtxt(...) 通常会抛 FileNotFoundError/OSError/ValueError,导致找不到 libs/hamming_matrix_*.csv 时不会走到 fallback 实现。建议改为捕获这些异常(或更宽泛的 Exception 并记录原因),并且用基于 __file__ 的绝对路径来定位 libs/,避免依赖当前工作目录。
| if __name__ == "__main__": | ||
| # main() | ||
| filename=["logs/convergence_test_ORBGRAND_20250427_100828.json"] | ||
| data_list = load_json_files(filename) | ||
| # merged_results, r_values, sigma_values, samplers = merge_code_length_results(data_list) | ||
| # visualize_code_length_results(merged_results, samplers, sigma_values, "ORBGRAND") | ||
| merged_results, r_values, sigma_values, samplers = merge_convergence_results(data_list) | ||
| visualize_convergence_results(merged_results, r_values, sigma_values, samplers, "ORBGRAND") |
There was a problem hiding this comment.
文件底部的 __main__ 逻辑把 main() 注释掉,并硬编码读取 logs/convergence_test_ORBGRAND_20250427_100828.json,会导致脚本在无该文件的环境下直接失败,也与上面的 argparse CLI 不一致。建议恢复 main() 作为默认入口,示例代码移到文档或用 --files/--type 参数驱动。
| # 将当前目录添加到Python路径 | ||
| sys.path.insert(0, os.path.dirname(os.path.abspath(__file__))) | ||
|
|
||
| from test_general import run_from_args, parse_args | ||
|
|
There was a problem hiding this comment.
run_experiment.py 依赖 test_general(from test_general import run_from_args, parse_args),但当前 reliable_sim/ 目录下不存在该模块,会导致脚本直接 ImportError。建议:要么把 test_general.py 纳入提交并确保可被相对导入;要么改为从实际存在的模块导入/重构为在本文件内定义 CLI 解析与实验入口。
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
| from test_general import * | ||
| from scipy.special import logsumexp |
There was a problem hiding this comment.
plot_general.py 顶部 from test_general import * 会在运行/导入时报 ImportError(仓库中未包含 test_general.py)。建议改为从现有模块显式导入所需符号,或补充缺失的 test_general.py 并将其作为 reliable_sim 包的一部分。
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task called "HighReliableSimulation" within the "WirelessChannelSimulation" domain. It focuses on estimating Bit Error Rate (BER) in a low BER regime using importance sampling techniques. The PR includes task definitions, evaluation scripts, baseline solutions, and documentation. It also provides guidelines for creating new Frontier-Eng tasks based on the 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 在 "WirelessChannelSimulation" 领域内引入了一个名为 "HighReliableSimulation" 的新基准测试任务。它侧重于使用重要性抽样技术在低误码率 (BER) 范围内估计误码率。该 PR 包括任务定义、评估脚本、基线解决方案和文档。它还提供了基于 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 在 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
|
…e_sim import coupling
Changes made: - (AI): Updated WirelessChannelSimulation and HighReliableSimulation README/Task/USAGE text for clearer task definition and execution guidance. - (AI): Removed outdated planning/calibration markdown files no longer aligned with current frozen evaluator setup. - (AI): Added .ralph-tui ignore entry in .gitignore. User raw prompts: - 太慢了!请你把现在的程序kill掉吧,先commit,然后用我们提供的贝塞尔函数法来作为initial program。这样也不用换sigma了。 - 你只提交和这次有关的修改和gitignore,其它不提交。 Co-Authored-By: Codex
Changes made: - (AI): Updated HighReliableSimulation initial program to make inherit from instead of . - (AI): Updated usage documentation to reflect Bessel-based initial program behavior. User raw prompts: - 太慢了!请你把现在的程序kill掉吧,先commit,然后用我们提供的贝塞尔函数法来作为initial program。这样也不用换sigma了。 - 好啊,请你commit。在此之前我想先确认一下:我要求的solver程序必须是一个继承了BaseSampler的类,这个BaseSampler现在在哪放着? Co-Authored-By: Codex
Changes made: - (AI): Added simulate_variance_controlled abstract interface to SamplerBase for unified solver contract. - (AI): Implemented simulate_variance_controlled in NaiveSampler and BesselSampler by delegating to code.simulate_variance_controlled. - (AI): Kept existing sample API intact and avoided changing evaluator call path. User raw prompts: - 这个sampler base必备的函数应该还有一个:sample variance controlled,因为我们最后会调用的是这个函数。请你修改所有相关的类来确保他们都有这个接口。另外再确认一下,evaluator是调用的sample variance controlled而不是sample函数吧? - 太好了,请你commit Co-Authored-By: Codex
Changes made: - (AI): Create /benchmarks/WirelessChannelSimulation/HighReliableSimulation/references with a short README describing suggested structure. - (User): Add Bucklew (2003) paper PDF into the references folder. User raw prompts: - 帮我创建这个题目的参考文献文件夹 - 好了,我刚刚又放进了一篇论文。现在整个commit然后push Co-Authored-By: GPT-5.2
…_sim Changes made: - (AI): Removed the standalone tree and migrated task dependency to the in-task runtime implementation under . - (AI): Reduced retained runtime components to Hamming code, binary hard decoding path, Chase decoder, Naive sampler, and Bessel sampler. - (AI): Removed calibration artifacts (, ) and updated task docs to remove stale references. - (User): Requested strict deletion of non-essential/research code and keeping only task-local required components. User raw prompts: - 好,那你执行吧。注意,只把公共组件(码、译码器、sampler base、打分器)放入这个包,而把任务的解放在包外,因为它是需要不断被重写的。 - 我发现了一个非常重要的问题:没有把代码清理干净!!这里面还有我之前做研究的时候写的未发表的代码!!请你只保留必要组件:汉明码,汉明码的标准硬译码算法和chase译码器,naive sampler和贝塞尔函数法的sampler。删除RM码,GRAND系列译码器,和SymShiftSampler,CutoffSampler,FixedShiftSampler等先进算法! - 这些额外内容所依赖的一些额外的类和函数也一并删掉!只保留必要组件!我们的initial program和验证器都只是基于贝塞尔函数法就行! - 把多余的文件全都删除!只保留你现在包里面的这些文件,外面的多余文件例如hamming simulation,绘图代码,find snr等都删掉!! - 我才发现,reliable_sim是一个独立的文件夹!!!不对,这道题的所有相关代码都应该放在这道题的文件夹底下,不应该有一个游离在外面的文件夹!!请你按照 [README.md](README.md) 的要求组织文件,把reliable_sim整个删掉,移动必要的代码! - 有几个和校准有关的文件,是我当时为了找到一个适合作为题目的SNR而写的,请你判断他们还有没有用,没用了就删掉。另外,hamming matrix csv系列文件可能还真的有用,因为要靠他们生成汉明码的矩阵,请你检查一下现在有没有用到他们。 - 好的,请你最后再跑一遍项目提供的测试程序,看看我们的initial program能得多少分。如果没问题就commit Co-Authored-By: Codex
Changes made: - (AI): Merged non-duplicate usage/interface details into `benchmarks/WirelessChannelSimulation/HighReliableSimulation/Task.md` and verified signatures against evaluator/runtime. - (AI): Removed `benchmarks/WirelessChannelSimulation/HighReliableSimulation/USAGE.md` and updated `benchmarks/WirelessChannelSimulation/HighReliableSimulation/README.md` references to point to Task. - (User): Requested including `AGENTS.md` deletion in the same commit. User raw prompts: - USAGE文档可以删掉了,如果有用内容都移到了Task里面。然后commit - 把删除agents的改动一并提交。另外看看其它文档有没有提到USAGE,有的话清除相关内容(redirect到Task),然后commit - 对比两个文档,把所有非重复部分都写入Task Co-Authored-By: Codex
…n evaluator error handling Changes made: - (AI): Converted WirelessChannelSimulation and HighReliableSimulation docs to concise bilingual pairs using README.md/README_zh-CN.md and Task.md/Task_zh-CN.md naming. - (AI): Reduced over-documentation by keeping only required task contract, run instructions, and scoring essentials. - (AI): Tightened evaluator try-except usage by narrowing optional import handling and wrapping candidate-facing failures with explicit RuntimeError paths. User raw prompts: - 项目作者给我们的PR提了review: README、Task等文件要提供中英两份。命名规范参考SingleCellAnalysis样例。不要过度文档化 先本地解决冲突再推送 慎用try-except确保实现逻辑正确 请你逐个解决。 Co-Authored-By: Codex
2cdb379 to
dddef03
Compare
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, "HighReliableSimulation," focusing on estimating the Bit Error Rate (BER) for Hamming(127,120) code over Additive White Gaussian Noise (AWGN) channels using variance-controlled simulation. It includes task descriptions in both English and Chinese, a baseline solution, evaluation scripts, runtime components, and references. The goal is to implement a 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 "HighReliableSimulation",重点在于使用方差控制仿真来估计加性高斯白噪声 (AWGN) 信道上 Hamming(127,120) 码的误码率 (BER)。它包括英文和中文的任务描述、基线解决方案、评估脚本、运行时组件和参考资料。目标是实现一个继承自 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
…glish copy Changes made: - (AI): Restored the original long-form literature review content in benchmarks/WirelessChannelSimulation/README.md. - (AI): Synced a Chinese copy to benchmarks/WirelessChannelSimulation/README_zh-CN.md to prevent accidental loss. - (AI): Added benchmarks/WirelessChannelSimulation/README_en.md as an English counterpart of the literature review. User raw prompts: - 文件夹README不要删掉!!!里面是我写的文献综述!!!!这是最重要的文档!!!把它恢复,并形成中英两份 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, "HighReliableSimulation," focusing on estimating the Bit Error Rate (BER) for Hamming(127,120) code over an Additive White Gaussian Noise (AWGN) channel using variance-controlled simulation. It includes task descriptions in both English and Chinese, a baseline solution, runtime components, an evaluator, and references. The core requirement is to implement a 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 "HighReliableSimulation",重点在于使用方差控制仿真来估计 AWGN 信道上 Hamming(127,120) 码的误码率 (BER)。它包括英文和中文的任务描述、基线解决方案、运行时组件、评估器和参考资料。核心要求是实现一个继承自 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
Changes made: - (AI): Added minimal type annotations for local variables flagged by mypy in runtime simulation loops. - (AI): Added decoder non-null assertions before dynamic decoder method calls to satisfy optional-type safety. - (AI): Annotated score in Chase decoder to avoid implicit Any in typed checks. User raw prompts: - 请你进行一下语法检查和类型检查,确保代码无误。 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
Changes made: - (AI): Added root pyrightconfig.json with runtime extraPaths so task-local imports resolve under static analysis. - (AI): Updated evaluator artifact typing to dict[str, str | bytes] to match EvaluationResult signature. - (AI): Renamed HammingCode.encode override parameter to match base signature and added non-null assertion before decoder radius access. User raw prompts: - pylance告诉我现在的代码仍有错误!请你继续检查。 - 我改的我已经commit了,请继续 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
Changes made: - (AI): Added unittest-based integration test to verify evaluator can load and score scripts/init.py end-to-end. - (AI): Asserted presence of core metrics and basic value sanity checks for reviewer reproducibility. User raw prompts: - 评论说:但是,提供的差异中没有明确提及单元测试或集成测试的存在,这是一个潜在的改进领域。请你做一个测试。 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
Changes made: - (AI): Added a dedicated PR workflow to run WirelessChannelSimulation HighReliableSimulation integration test. - (AI): Configured Python 3.10 and minimal dependencies (numpy, scipy) before running unittest. User raw prompts: - 把它加入GitHub actions的自动测试?然后就可以更新PR了。 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task called "HighReliableSimulation" for estimating the Bit Error Rate (BER) of Hamming(127,120) code over Additive White Gaussian Noise (AWGN) channels. It includes task definitions, baseline solutions, evaluation scripts, and a GitHub Actions workflow for automated testing. 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个名为 "HighReliableSimulation" 的新基准测试任务,用于估计加性高斯白噪声 (AWGN) 信道上 Hamming(127,120) 码的误码率 (BER)。它包括任务定义、基线解决方案、评估脚本以及用于自动测试的 GitHub Actions 工作流程。 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
repo = Path(".").resolve() spec = importlib.util.spec_from_file_location("hrs_eval", str(eval_path)) |
Changes made: - (AI): Replaced long heredoc run examples with one-line evaluator command in HighReliableSimulation README (EN/ZH). - (AI): Added CLI entrypoint to evaluator.py so works directly. - (AI): Removed root-level pyrightconfig.json to avoid personal/local root configuration in PR. User raw prompts: - 根目录下的自己的个性化修改不要推上来(比如.gitignore,pyrightconfig.json) 文档中如何运行部分不要用AI生成: python - <<'PY' import importlib.util from pathlib import Path repo = Path(.).resolve() eval_path = repo / benchmarks / WirelessChannelSimulation / HighReliableSimulation / eval / evaluator.py program = repo / benchmarks / WirelessChannelSimulation / HighReliableSimulation / scripts / init.py spec = importlib.util.spec_from_file_location(hrs_eval, str(eval_path)) mod = importlib.util.module_from_spec(spec) spec.loader.exec_module(mod) print(mod.evaluate(str(program), repo_root=repo)) PY 这个太长太丑了,eval命令最好就一行,比如这种风格: python verification/evaluator.py scripts/init.py - 这次修改完后不要立刻push。等我检查完再push Co-Authored-By: Codex
Changes made: - (AI): Replaced Any-based annotations in scripts/init.py and baseline/solution.py with strict HammingCode annotations. - (AI): Switched runtime imports to repo-root absolute module paths so evaluator, init, and baseline share consistent class identities. - (AI): Updated evaluator dynamic loading to use package-qualified runtime modules and re-calibrated R0_DEV from 1e6-sample baseline runs. User raw prompts: - 不要随便用any!宁可无法通过类型检查也要把约束弄严格!这里就应该是hamming code,至少也是linear code base。先把你在跑的程序放到后台,然后修改这个 Co-Authored-By: Codex
Changes made: - (AI): Set R0_DEV to the 9-run geometric-mean BER calibration value. - (AI): Set T0_DEV to the 9-run arithmetic-mean runtime calibration value. - (AI): Updated calibration comment to document the averaging method. User raw prompts: - 9次的测量结果分别是多少?错误率取他们的几何平均,时间取他们的算术平均,如果没有离群值的话。 - 好的,把这两个数字作为基准。然后commit并push Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
Changes made: - (AI): Set R0_DEV to arithmetic mean BER from 10 runs at 1e7 samples each. - (AI): Set T0_DEV to arithmetic mean runtime from the same 10-run calibration. - (AI): Updated calibration comment to reflect 10-run 1e7-sample arithmetic-mean method. User raw prompts: - 再算一下这次的错误率算术平均 - 把这个错误率和104.001037335396 s作为标准答案,然后commit Co-Authored-By: Codex
|
目前存在的问题:
这里的初始程序init.py应当提供一个能正常运行的程序,但是结果valid==0.0 |
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive SummaryThis PR introduces a new benchmark task, 2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
🇨🇳 中文分析1. 摘要此 PR 引入了一个新的基准测试任务 2. AI 成分分析
3. 工程与经济评估
4. 质量保证
|
…re baseline Changes made: - (AI): Migrated HighReliableSimulation evaluator entry from eval/ to verification/, updated task wiring and integration tests, and removed eval-path documentation references. - (AI): Added verification requirements file and aligned task/domain READMEs with official verification-based quick-start commands and task name docs. - (AI): Reduced scoring baseline by setting T0_DEV from 104.001037335396 to 10.4001037335396 and validated via wireless CI unittest plus evaluator run. User raw prompts: - 那就把你之前写的eval文件夹删掉。再检查一下我们这道题,看看其它文件是否符合项目规范。 - T0_DEV = 104.001037335396改为现在的1/10,最后做一遍CI测试,没问题就commit并push。更新PR的时候记的回复审稿人的意见 Co-Authored-By: Codex
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive Summary
2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
5. Security & Privacy Check
🇨🇳 中文分析1. 摘要
2. AI 成分分析
3. 工程与经济评估
4. 质量保证
5. 安全与隐私检查
|
|
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive Summary
2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
5. Security & Privacy Check
🇨🇳 中文分析1. 摘要
2. AI 成分分析
3. 工程与经济评估
4. 质量保证
5. 安全与隐私检查
|
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive Summary
2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
5. Security & Privacy Check
🇨🇳 中文分析1. 摘要
2. AI 成分分析
3. 工程与经济评估
4. 质量保证
5. 安全与隐私检查
|
🤖 AI Code Review (google/gemini-2.0-flash-001)🇬🇧 English Analysis1. Executive Summary
2. AI Content Analysis
3. Engineering & Economic Assessment
4. Quality Assurance
5. Security & Privacy Check
🇨🇳 中文分析1. 摘要
2. AI 成分分析
3. 工程与经济评估
4. 质量保证
5. 安全与隐私检查
|
背景(Background)
本 PR 在
WirelessChannelSimulation领域下新增任务HighReliableSimulation。任务面向超低误码率(稀有事件)场景:线性纠错码在 AWGN 信道、反相 BPSK 调制下的译码错误率估计。由于朴素蒙特卡洛在极低错误率下需要海量样本,本任务评测重点放在重要性采样 + 方差控制,以在固定计算预算内实现可复现、可验证的误码率估计。
来源与参考(Source / References)
reliable_sim的核心接口;为便于复现与降低耦合,在benchmarks/WirelessChannelSimulation/HighReliableSimulation/runtime中包含了运行所需的最小依赖代码。benchmarks/WirelessChannelSimulation/HighReliableSimulation/references(包含 Bucklew 等人的相关论文)。如何运行验证(How to Run Verification)
在仓库根目录运行评测器,对提供的示例程序进行一次打分: