Repository navigation
fix(select): ignore selection after disabling - #23154
Open
Xapollon430 wants to merge 1 commit into
Open
Xapollon430 wants to merge 1 commit into
Xapollon430 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
disabledtotruewhile the dropdown is open.changestill fires.Watch the browser reproduction.
The recording uses Element's theme and ordinary pointer input against the original
devsource and the same source with the fix.Check the effective disabled state in
handleOptionSelect. This covers a disabled Select or disabled enclosing Form without changing how the popup opens or closes. Re-enabling the Select restores normal selection.I started investigating this transition while testing Anta with Hegel and Bombadil, then reproduced it in Element independently.
Validation
All 35 Select tests pass in Chromium through Karma. The new regression fails on the original source.
Chromium reproduction: before, Orange and one change; after, Apple and zero changes.
Scoped lint passes.
npm run diststops at an existing missing newline insrc/locale/lang/lo-LA.js, reproduced on the original source.Followed the contributing guide.
Targets
dev.Includes reproduction and regression coverage.
AI-assisted implementation and testing.