Issue with col-width calculation

[SL-Gundam]

Hi,

I ran into an issue with Markdownify because it calculates table col-width based on string length. This resulted in incredibly long col-widths because there were several paragraphs of text in a field.
So what if a string is actually multiple lines. It would be better to calculate the longest line length instead of the full string.

But i don't know if multiple lines in markdown tables is even a possibility.

Option A: Prevent tables when a field contains multiple lines of text
Option B: Calculate longest line length in the string instead of the full string.

I have a version where option B works.
Should i make a pull request for option B or should i start work on option A? Or some other method to deal with this.

SL-Gundam@63d6d4f
SL-Gundam@3bb0bff

Thanks again for this great library.

[tzi]

Thanks for the detailed report, and for looking into it!

There is a bigger problem hiding behind this one. Markdown tables cannot contain line breaks. A line break ends the row. So today the output is not just too wide, it is broken.

<td>one<br>two</td>

=>

| A         | B        |
| --------- | -------- |
| one
two | xxxxxxxx |

The row splits in two. No Markdown renderer will show that as a table.
I tried your two commits on that same input. The column gets narrower, but the table is still broken.

What I suggest instead: turn the line breaks into <br> before measuring the width. Both Markdown Extra and GitHub understand <br> inside a table cell, so the table stays valid and the width becomes correct again.

Expected generated markdown:

| A          | B        |
| ---------- | -------- |
| one<br>two | xxxxxxxx |

This is a one-line change in the cell handling code.
It also means no extra helper function is needed.

One question for you. Even with this fix, a cell holding one long paragraph still makes a wide column. If that is your real pain, the answer is a maximum column width setting, not a better measurement. Which of the two is bothering you more?
If you are happy with the
approach, a pull request would be very welcome.

Please add a test for it.

[SL-Gundam]

That answers Option A. No line break support for markdown.

Part of the problem was the wide column. I still need to cut down on col-width.
I have situations where the markdown col-width just becomes ridiculous. See below for Variant3 from this issue: #31 (comment)

The col-width becomes so large is not an annoyance but something that causes actual problems to work with.

I will look into a maximum column width setting.

[SL-Gundam]

Made the necessary changes.
I did still need the extra helper function. And another one for the nl2br (the php version nl2br would not have worked)
If you feel this solution is good then i will create the pull request.
Should i also add a test case to cover the scenario?

SL-Gundam@12496bc

[SL-Gundam]

The line endings code does not work as expected. I removed that code from the pull request. So now it only deals with limiting max column width.

Will look further into the line endings conversion

[SL-Gundam]

Alright. For the discussed situations #51 should fix the problems.
Sorry it took it bit longer. This weekend I did not have time and ran into issues getting the code to work.
The code did not work properly because of another issue Markdownify does not properly handle: Tables in tables. I will try to fix that separately from this. If i find a good solution i will create another pull request.
#50 and #51 can be closed if you approve as-is.

[SL-Gundam]

I've made a modification which ignores nested tables.
SL-Gundam@0f9783a
Shall i add this to the pull request #51? or does it require more work?
I believe it fixes Variant 2 and 3 from #31 (comment) to a satisfactory level.