This repository was archived by the owner on Feb 25, 2022. It is now read-only.
Fixing create_tfrecords.py when using custom tokenizer#144
Open
galloj wants to merge 1 commit into
Open
Conversation
Member
|
This looks reasonable, but I haven't been able to test it yet. Just wanted to let you know that I am aware of this PR and it's on the to-do list. |
StellaAthena
suggested changes
Mar 25, 2021
StellaAthena
left a comment
StellaAthena
left a comment
Member
There was a problem hiding this comment.
Changes to main have made this PR conflict. Please pull the most recent version and resolve the conflicts on your fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing error when loading tokenizer using encoder_path. Also I added some error messages, because all errors which happened because of bad input were mostly unreadable.
I think it would be nice to do some more refactoring on this file too, because I think there will be bad handling of errors in other cases too. Also I had issue when multiple threads were used, then multiple tensorflow instances were initialized at once, which caused that both of them printed at same time, which resulted in letters being printed in random order.