Repository navigation
Avoid resolving aliased expression fields twice - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror the single-resolution
Expr::Alias::to_fieldfix from apache#26156 into the DataFusion 55 fork.metadata()already callsto_field(); calling both recursively made nested alias field inference exponential.The regression test shows 12 aliases changing from 4,096 source-field lookups to one, and checks metadata precedence, field name, type, and nullability. Execution kernels are unchanged.
Validation
cargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p datafusion-expr --lib(253 passed)This PR does not change the DataFusion revision pinned by Rustice; that update can follow independently.