REC-110: refactor to remove CacheAlert #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the beginning of a refactoring to move some LoadStorer implementations into appState. Although CacheAlert satisfied the LoadStorer interface type, it was a decorator that didn't actually load or store any tokens or provide useful or meaningful abstraction. It seems better to squash this into appState and remove unnecessary abstraction. This also makes the test a little more realistic. Also refactored fake token generation to make testing easier.
jayconrod
force-pushed
the
jay-1-cachealert
branch
from
f3dd524 to
412f736
Compare
rogerhu
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of a refactoring to move some LoadStorer
implementations into appState.
Although CacheAlert satisfied the LoadStorer interface type,
it was a decorator that didn't actually load or store any tokens
or provide useful or meaningful abstraction. It seems better to
squash this into appState and remove unnecessary abstraction.
This also makes the test a little more realistic.
Also refactored fake token generation to make testing easier.