Skip to content

Demos 2404 demonstration create edit dialogs#1540

Draft
connor-parke-icf wants to merge 5 commits into
post-launchfrom
DEMOS-2404_demonstration_create_edit_dialogs
Draft

Demos 2404 demonstration create edit dialogs#1540
connor-parke-icf wants to merge 5 commits into
post-launchfrom
DEMOS-2404_demonstration_create_edit_dialogs

Conversation

@connor-parke-icf

@connor-parke-icf connor-parke-icf commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Main goal here was to decouple the Create and Edit demonstration dialogs as the components were getting bulky with create vs edit, and approved vs unapproved. So i implemented a refactor. As part of this, i broke up the components into different files, mainly:

  • a wrapping component, where user context and an initial demonstration is generated/fetched
  • the main dialog component, where states, mutations, and validations are triggered
  • a form component, where the actual form html is put
  • and finally a couple of hooks for handling the query and mutation.
    The same structure is copied to the EditDemonstrationDialog. Because the package now spans multiple files, i bundled them together into CreateDemonstration and EditDemonstration subfolders.

There should not be any effect on the actual behavior or appearance of these dialogs, just relaxing their hold on each other behind the scenes.

@github-actions github-actions Bot added the client Relates to the client. label Jul 8, 2026
@demos-git-service-account

demos-git-service-account commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants