refactor MPI constant binding with a generic API - #3052
Merged
Merged
Conversation
wsmoses
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just like in #3051, this pr refactors the way we set the MPI constants to be less cumbersome. it basically adds a
enzymexla_set_mpi_constantfunction that adds a mapping between the MPI constant name and the value.an alternative would be to reuse the JIT registry of symbols just like LowerEnzymeXLAMPI pass does, but i find this better because it makes explicit the fact that we are directly storing integer values as pointers.
note that when/if we require the MPI 5 ABI (but it's not yet widespread), this wouldn't be a problem and we could remove this API.