Repository navigation
Add OffsetViewInterface to pointer conversions - #3377
Merged
Merged
Conversation
Mark pointer2memref and memref2pointer as address-preserving views. Require pointer2memref result layouts to have zero offset. Test both base-object queries and rejection of nonzero or unknown result offsets. Assisted-By: OpenAI Codex
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
==========================================
- Coverage 29.61% 29.61% -0.01%
==========================================
Files 239 240 +1
Lines 48403 48460 +57
==========================================
+ Hits 14336 14351 +15
- Misses 34067 34109 +42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointer conversions preserve the starting address, but
getBaseObject(value, false)cannot follow them withoutOffsetViewInterface.Add the interface to
enzymexla.pointer2memrefandenzymexla.memref2pointer. Require a zero offset in the result layout ofpointer2memref, so the interface guarantee holds. Existing offsets in the source remain intact.This extracts the shared interface change from #2744, as requested in review. The required Enzyme version is already on main through #3373.
Validation: the optimized build passes. The full LIT suite has 1,415 passes and 9 expected failures, with no unexpected failures. New tests check both base-object modes, nonzero GEP and subview offsets, and invalid result layouts.