Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3411 +/- ##
=======================================
Coverage 29.61% 29.62%
=======================================
Files 240 240
Lines 48460 48474 +14
=======================================
+ Hits 14351 14359 +8
- Misses 34109 34115 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TODO in
getMaxSharedMemsays a block can use more than 48KiB of shared memory, but only as dynamic shared memory:Enzyme-JAX/src/enzyme_ad/jax/Passes/ConvertParallelToGPU.cpp
Line 2591 in 44f289b
This PR makes
convert-parallel-to-gpu2use dynamic shared memory when a kernel needs more than 48KiB:cudaFuncSetAttribute(kernel, cudaFuncAttributeMaxDynamicSharedMemorySize, size). [CUDA requires this call before a launch can use more than 48KiB, and appling the setting only to the current device, so it is made before every launch