Skip to content

Remove unnecessary rule for hvcat_fill! - #3490

Merged
wsmoses merged 1 commit into
EnzymeAD:mainfrom
yuyichao:hcat-rm
Sep 1, 2026
Merged

wsmoses merged 1 commit into
EnzymeAD:mainfrom
yuyichao:hcat-rm

Conversation

@yuyichao

Copy link
Copy Markdown
Contributor

The new version in base should be type stable now.

It might be better to change the test to test the higher level function that uses hvcat_fill! but I'm still working on other changes to make it run on master.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.99%. Comparing base (70af14d) to head (0eb9ee1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3490       +/-   ##
===========================================
+ Coverage   44.21%   76.99%   +32.77%     
===========================================
  Files          55       68       +13     
  Lines       21509    22668     +1159     
===========================================
+ Hits         9511    17454     +7943     
+ Misses      11998     5214     -6784     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The new version in base should be type stable now
@wsmoses
wsmoses merged commit f31d390 into EnzymeAD:main Sep 1, 2026
76 of 79 checks passed
@vchuravy vchuravy mentioned this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants