Fix jit lookup on master - #3491
Merged
Merged
Conversation
In EnzymeAD#3102, addition JITDylib is passed to the LLVM.jl API to satisfy the API change. However, [as at-wsmoses pointed out](EnzymeAD#3102) the JITDylib passed in for lookup is a fresh one, which does not include the jitted function, causing the lookup to fail on recent julia version. There are still two uses of `JIT.lookup` in `src/compiler/validations.jl` that does not pass in the `JITDylib` explicitly but those are looking up internal symbols AFAICT so it is probably fine. The current version also keeps all explicit use of JITDylib to the `orcv2.jl` file which seems to be the intention.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3491 +/- ##
==========================================
- Coverage 78.61% 76.99% -1.62%
==========================================
Files 68 68
Lines 22930 22668 -262
==========================================
- Hits 18026 17453 -573
- Misses 4904 5215 +311 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vchuravy
approved these changes
Aug 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3102, addition JITDylib is passed to the LLVM.jl API to satisfy the API change. However, as @wsmoses pointed out the JITDylib passed in for lookup is a fresh one, which does not include the jitted function, causing the lookup to fail on recent julia version.
There are still two uses of
JIT.lookupinsrc/compiler/validations.jlthat does not pass in theJITDylibexplicitly but those are looking up internal symbols AFAICT so it is probably fine. The current version also keeps all explicit use of JITDylib to theorcv2.jlfile which seems to be the intention.