Repository navigation
Conversation
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
Quite interesting, but has some issues.
I will definitely try to play with it
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| pip install nox pytest |
There was a problem hiding this comment.
The main point of micromamba is to provide a way to install all dependencies.
If we need to install nox and pytest before micromamba then why do we need micromamba?
There was a problem hiding this comment.
Yeah, I didn't consider that part.
| # Bazel 7 provided by micromamba is compiled using a newer java version | ||
| # than the default in Github runner | ||
| - name: Set up JRE 21 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '21' | ||
| distribution: 'temurin' | ||
| java-package: 'jre' |
There was a problem hiding this comment.
That's interesting. I do not see that in Jenkins. Should this be fixed in micromamba env?
There was a problem hiding this comment.
That is indeed fascinating. I don't think we should place too big an emphasis on it, since it is a Bazel dependency. (I expect projects using Bazel to have an environment working with the Bazel binary.)
|
|
||
| - name: Install micromamba and run tests | ||
| run: | | ||
| source .ci/nox/install.sh |
There was a problem hiding this comment.
Here we basically install micromamba, not nox
| @@ -0,0 +1,73 @@ | |||
| """ | |||
There was a problem hiding this comment.
Can this file be located in .ci/nox/?
There was a problem hiding this comment.
Nox seems to want the file at the root of the git project folder. I'm sure it can be changed.
|
Since this basically just introduces another program dependency unnecessarily, let's skip this patch. |
Why:
We want a stable testing framework that supports testing with different Bazel, Python, and Codechecker versions
What:
Notes:
Addresses:
#163