Skip to content

fix: Use json output for severities - #349

Merged
Szelethus merged 3 commits into
Ericsson:mainfrom
furtib:use-json-output-when-scripting
Oct 26, 2026
Merged

Szelethus merged 3 commits into
Ericsson:mainfrom
furtib:use-json-output-when-scripting

Conversation

@furtib

@furtib furtib commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Why:
CodeCheckers user facing ui can (and has) changed.
Let's use the much more consistent JSON output instead.

What:

  • Rewrote the check_results function to use the JSON output instead of the human-readable one.

Addresses:
Fixes: #348

@furtib
furtib requested a review from Szelethus October 9, 2026 12:18
@furtib furtib self-assigned this Oct 9, 2026
@furtib furtib added the bug Something isn't working label Oct 9, 2026
@furtib
furtib force-pushed the use-json-output-when-scripting branch from 5bb4cb1 to d9b0e09 Compare October 9, 2026 12:24
Comment thread src/common.py
Comment thread src/common.py
@furtib

furtib commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

I created a test for this in #360. Let me know if I missed anything!

@furtib
furtib force-pushed the use-json-output-when-scripting branch 2 times, most recently from 1b32c51 to 819f8b3 Compare October 21, 2026 10:22
@furtib

furtib commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I have added the tests merged in #360 and made changes where necessary.

@furtib
furtib force-pushed the use-json-output-when-scripting branch from 819f8b3 to d301c30 Compare October 21, 2026 11:27

@Szelethus Szelethus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look like a very no-nonsense patch. Alex, do you foresee any challanges?

@Szelethus Szelethus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, the patch looks great btw.

@furtib
furtib force-pushed the use-json-output-when-scripting branch from d301c30 to 115e088 Compare October 26, 2026 09:10
@Szelethus
Szelethus merged commit b066d0e into Ericsson:main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing monolithic tests pass on newer codechecker version

3 participants