Repository navigation
Conversation
| py_interpreter_dir = py_toolchain.py3_runtime.interpreter.dirname | ||
|
|
||
| # TODO: remove /bin when dirname is available hermetically | ||
| env["PATH"] = (env.get("PATH", "") + ":" + py_interpreter_dir + ":/bin").lstrip(":") |
There was a problem hiding this comment.
I will make it match the monolithic version.
It just occurred to me that if users specify PATH, the Python interpreter will be booted from the path of the monolithic one.
1fa2205 to
ea835b9
Compare
ddd3db1 to
12645dd
Compare
|
I tried to make this PR as neat as possible. |
12645dd to
4de5dbf
Compare
nettle
left a comment
nettle
left a comment
There was a problem hiding this comment.
I think we should agree on wanted position for this problem.
As I can see this changes just trying to use python3 from the toolchain for CodeChecker which in turn might be incompatible. CodeChecker has in fact more dependencies.
|
Oh, right, what if the python version of the codechecker installation and the one provided by rules_python differ........ |
Why:
We want a hermetic rule.
In PR #308 I noticed that removing
/bincauses the tool to fail, saying that/usr/bin/env python3 cannot be found. For this reason, we need to add not only dirname but also the hermetic python interpreter to the PATH.What:
Addresses:
#362
Depends on: #363