Rewrite reminders, break apart GlobalCmds#342
Open
FloatingMilkshake wants to merge 2 commits intomainfrom
Open
Rewrite reminders, break apart GlobalCmds#342FloatingMilkshake wants to merge 2 commits intomainfrom
FloatingMilkshake wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289
Rewrites reminders to add more functionality. Uses my code from https://github.com/FloatingMilkshake/MechanicalMilkshake/blob/040995d/Commands/ReminderCommands.cs with some changes to fit Cliptok instead. Also breaks apart
GlobalCmdsintoReminderCmds,HelpCmds,UserInfoCmds,PingCmds!remindershould be kept totally intact, and reminder creation & triggering should look the same to users. However there is now a new/remindercommand group, with options to set/modify/delete/list/show reminders, and a "Remind Me About This" message context menu command.Reminders are still restricted to Tier 4 in the home server, and the text command works in DMs. I did not test slash/interaction usage in DMs because I guess we don't register interaction commands globally on dev, and I didn't want to mess with that. (or maybe we do and I just messed up)