Update host-client.js for better handling of missing messageKey#240
Open
gadget78 wants to merge 2 commits into
Open
Update host-client.js for better handling of missing messageKey#240gadget78 wants to merge 2 commits into
gadget78 wants to merge 2 commits into
Conversation
improved missing message key handling on tenants account, so it doesn't throw fault and stop code when it isn't present, (which produces orphaned/ghost instance) this PR will make it continue with the instance data omitted, with a error message in its place instead. we could as an alternative, default to unencrypted ? but i feel this is a safer method. as could always use the already in place method of having options.messageKey = 'none' instead if needed ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improved missing message key handling on tenants account,
so it doesn't throw fault and stop code when it isn't present, (which produces orphaned/ghost instance)
this PR will make it continue with the instance data omitted, with a error message in its place instead.
we could as an alternative, default to unencrypted ?
its only used to encrypt the instance info on acquire success currently. so i feel omitting info is a safer method.
as could always implement the already in place method of having
options.messageKey = 'none'within sashi agent if needed ?this only occurs when using a different method of signing acquire lease type functions, (as they are not initialised )
which is where I found the fault, when tenants use Xaman to acquire a lease and their accounts are not set with message key.