Fix missing @vercel/ncc dependency in subdirectory builds#17
Open
rippleitinnz wants to merge 1 commit into
Open
Fix missing @vercel/ncc dependency in subdirectory builds#17rippleitinnz wants to merge 1 commit into
rippleitinnz wants to merge 1 commit into
Conversation
## Problem The `npm run bundle` command fails when building from a fresh clone because the lobby and gp-port-server subdirectories use `npx ncc` without having @vercel/ncc as a dependency. Error encountered: npm error could not determine executable to run ## Root Cause The main package.json includes @vercel/ncc, but the subdirectories that use `npx ncc build` in their build scripts don't have it listed as a dependency. ## Solution Add @vercel/ncc v0.34.0 (matching main package.json version) to dependencies in: - dependencies/lobby/package.json - dependencies/gp-port-server/package.json ## Testing - Verified `npm run bundle` now completes successfully in fresh environments - Confirmed Docker containerized builds work without manual dependency installation - No impact on existing functionality ## Impact Enables reliable builds from fresh clones and containerized environments without requiring manual setup steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
npm run bundlecommand fails when building from a fresh clone because the lobby and gp-port-server subdirectories usenpx nccwithout having @vercel/ncc as a dependency.Error encountered: npm error could not determine executable to run
Root Cause
The main package.json includes @vercel/ncc, but the subdirectories that use
npx ncc buildin their build scripts don't have it listed as a dependency.Solution
Add @vercel/ncc v0.34.0 (matching main package.json version) to dependencies in:
Testing
npm run bundlenow completes successfully in fresh environmentsImpact
Enables reliable builds from fresh clones and containerized environments without requiring manual setup steps.