SOF-7849: allow material context for python, deepmd and lammps#101
Open
SOF-7849: allow material context for python, deepmd and lammps#101
Conversation
…such as buildConfig as same hash is shared by py and js tests
pranabdas
commented
Apr 19, 2026
| esse = ESSE() | ||
| schema = esse.get_schema_by_id(APPLICATION_SCHEMA_ID) | ||
| allowed_keys = _collect_schema_property_names(schema) | ||
| config = {k: v for k, v in self.to_dict().items() if k in allowed_keys} |
Member
Author
There was a problem hiding this comment.
A better approach could be to implement Python validate_and_clean method in esse, keeping parity with JavaScript validateAndClean.
| "nwchem", | ||
| "python", | ||
| "vasp", | ||
| ] |
Member
There was a problem hiding this comment.
Is there a way to get this from standata instead?
timurbazhirov
approved these changes
Apr 22, 2026
| # attached by standata) at construction time, so `calculate_hash` stays | ||
| # aligned with the JS side, which performs the same schema-driven filtering | ||
| # inside `Application.toJSON()`. | ||
| model_config = ConfigDict(extra="ignore") |
Member
There was a problem hiding this comment.
Let's add into the comment that build_config will be stripped
…eparately looking it up from standata
|
Coverage after merging feat/SOF-7849 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.