feat/SOF-7249: JS -> TS conversion#117
Open
seankwarren wants to merge 17 commits intoepic/SOF-6048from
Open
Conversation
added 14 commits
February 11, 2024 17:54
This was referenced Feb 12, 2024
pranabdas
reviewed
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to asset generation:
Previously assets were generated by
build_filter_trees.jsandbuild_templates.jsin the root directory. Due to the dual repo (js/python) nature of the repo, these have been moved inside thesrc/jsfolder.build_templates.jshas been renamed tobuild_application_trees.tsto better match its responsibility. Additionally, the asset generation has been updated to run directly on the new ts generation scripts viats-node(see package.json scripts). The generated assets are now generated as const in typescript and included in transpilation, resulting in declaration files for these object assets.Example:
old:
new:
How to update:
Package Exports Added
allowedApplications, andallowedPostProcessorsas new package exportsAllowedApplications,AllowedResults,AllowedMonitors,AllowedPostProcesorsPackage Exports Renamed
applicationTree->applicationExecutableFlavorTree: the nested application, executable, flavor heirarchygetAppTree->getApplicationExecutableFlavorData: get an application fromapplicationExecutableFlavorTreeapplicationData->applicationVersionBuildTree: the nested application, version, build heirarchygetAppData->getApplicationVersionBuildData: get an application fromapplicationVersionBuildTreegetAllAppTemplates->loadApplicationTemplates: loads the template yml assets and returns as jsongetAllAppData->loadApplicationVersionBuildTree: loads the application yml assets and returns as jsongetAllAppTree->loadApplicationExecutableFlavorTree: loads the executable yml assets and returns as jsonUpdate PRs:
Update test results: https://ci.mat3ra.com/job/Stack-SOF-20230525/1224/console