[Payment due @marufsharifi] Shrink Book a call avatar to match phone icon size#96233
Conversation
|
Coming from here, does this avatar size look okay?
|
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
That is likely because I don't have a real user account assigned to an account manager, so I seeded data for an account with an account manager in the development database. That data may be missing from this local database. These PRs didn't touch that functionality. Testing the ad hoc build with a real user who is assigned an account manager should show the banner correctly. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-16.at.2.25.26.PM.movAndroid: mWeb ChromeRecording_20260716_141931.mp4iOS: HybridAppScreen.Recording.2026-07-16.at.2.13.36.PM.moviOS: mWeb SafariScreen.Recording.2026-07-16.at.1.51.54.PM.movMacOS: Chrome / SafariScreen.Recording.2026-07-16.at.1.44.02.PM.mov |
|
@marufsharifi can you complete the review on this? |
|
@c3024, could you please merge the main? thanks. |
…-a-call-avatar-size
|
@marufsharifi Merged! Please have a look! |
|
🎯 @marufsharifi, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.41-0 🚀
|
Help site review: no changes requiredI reviewed the changes in this PR and no updates to the help site files under This is a purely presentational tweak — it shrinks the account manager avatar next to the "Book a call" text from I also searched Because no documentation change is warranted, I did not create a draft help-site PR. @c3024, no linked help site PR was created since this is a purely presentational change with no documentation impact. Please confirm you agree that no help site update is required. |
|
@c3024 @NikkiWines @flaviadefaria The account manager isn't assigned to the test accounts, so we're currently blocked from validating this flow. Is there any workaround for this, or should this be validated internally instead? |
|
This is just an icon change. This doesn't need to block the deploy, IMO. |
|
Who identified the icon was too large before? Can they confirm on staging that this looks fine now? cc: @zanyrenney @dubielzyk-expensify since I see you on the main issue |
|
@dubielzyk-expensify identified it, but I think he did so by checking the screenshots I added to the issue. I tested it by seeding an account manager for an account in the dev DB. |
|
Ok, in that case I think it's probably ok, checked it off ☑️ |


Explanation of Change
Follow-up to design feedback on the Book a call PR: the account manager avatar shown beside the "Book a call" text was too large. This shrinks it from
AVATAR_SIZE.SMALL(28px) toAVATAR_SIZE.MID_SUBSCRIPT(16px) so it matches the phone-icon variant's size (also 16px) and sits at roughly text height.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/650433
PROPOSAL:
Tests
Offline tests
This change is purely presentational; there is no offline-specific behavior. The button and avatar render the same regardless of network state.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari