refactor: feat_vs_anno_server to use run_from_json pattern#75
Open
fangliu117 wants to merge 5 commits intoFNLCR-DMAP:devfrom
Open
refactor: feat_vs_anno_server to use run_from_json pattern#75fangliu117 wants to merge 5 commits intoFNLCR-DMAP:devfrom
fangliu117 wants to merge 5 commits intoFNLCR-DMAP:devfrom
Conversation
- Delegate heatmap rendering to hierarchical_heatmap_template's run_from_json via memory registry, matching nearest_neighbor_server and ripleyL_server architecture. - Update spac pin to SCSAWorkflow commit 598517d which fixes the template to return (clustergrid, df) when save_results_flag=False. - Preserves all existing UI features: colormap, dendrogram toggles, axis rotation, label abbreviation, min/max range updates. Depends on: SCSAWorkflow PR #425
Add Feature(s),Z Score, Standard Scale, Swap Axes, Figure Title/Width/Height/DPI, Font Size, and Matrix Plot Ratio as configurable inputs instead of hardcoded values. Organized under collapsible Figure Configuration section.
- Refactored feat_vs_anno_server.py to use hierarchical_heatmap_template - Default colormap changed to seismic with dendrograms enabled - Fix ripleyL_server import: visualize_ripley_template -> visualize_ripley_l_template - Update spac pin to SCSAWorkflow commit 4bd1aaf (v0.9.3) - Expose all template parameters in Feat. Vs Anno. UI
Pre-existing bug on dev: NN and Ripley L templates use 'save_to_disk', not 'save_results'. Mismatch caused TypeError silently caught by except block, producing blank plots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: SCSAWorkflow PR #425