Fix AtomicLongDeserializer value truncation on coerced values#5931
Merged
cowtowncoder merged 1 commit intoFasterXML:3.xfrom Apr 20, 2026
Merged
Conversation
`AtomicLongDeserializer` used `Long.intValue()` on the `_parseLong(...)` path, which truncated values above `Integer.MAX_VALUE` for coerced String and floating-point inputs. Use `Long.longValue()` instead and add regression tests for both cases.
🧪 Code Coverage Report
|
| // 12-Jun-2020, tatu: May look convoluted, but need to work correctly with | ||
| // CoercionConfig | ||
| Long L = _parseLong(p, ctxt, AtomicLong.class); | ||
| return (L == null) ? null : new AtomicLong(L.intValue()); |
cowtowncoder
approved these changes
Apr 20, 2026
Member
|
Will merge and then backport in 3.1. |
cowtowncoder
changed the title
AtomicLongDeserializer value truncation on coerced values
cowtowncoder
pushed a commit
that referenced
this pull request
Apr 20, 2026
`AtomicLongDeserializer` used `Long.intValue()` on the `_parseLong(...)` path, which truncated values above `Integer.MAX_VALUE` for coerced String and floating-point inputs. Use `Long.longValue()` instead and add regression tests for both cases.
cowtowncoder
added a commit
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtomicLongDeserializerconverts throughLong.intValue()on the_parseLong(...)path, which silently truncates coerced values aboveInteger.MAX_VALUE.This changes that path to use
Long.longValue()and adds regressiontests for String and floating-point inputs above
Integer.MAX_VALUE.Testing:
./mvnw -q -Dtest=tools.jackson.databind.deser.jdk.JDKAtomicTypesDeserTest test