Repository navigation
Conversation
|
There's been a bit of disagreement about this but I'd personally prefer "Data Set" as two words, |
|
In "The Cost Model" - we don't touch on the 30 day lockup; there's a lot of coverage of lockups in the Filecoin Pay section, but specifically for storage, with FWSS, we should be clear that FWSS doesn't have a variable lockup, all you need to know is that you're always pre-paying 30 days for an active service. Then when you dip below 30 days in your balance you're essentially heading for default and the SP is going to treat you as delinquent and will schedule removal of your data. I suspect that using more simplified ways of talking about lockup without having to cover all of the complexities of lockup makes some of the problems go away. Also in the costing, we should be clear that "per month" means "per 30 days", not calendar month like a traditional storage service. A point Hugo was making yesterday that I think is worth being crystal clear about - we say "per month" for simplicity but you have to read that as "per 30 days" if you're doing any nontrivial calculation with it. The code in that cost model shows how broken our current API for pricing is .. we really need to get that fixed. In "Creating a Storage Context" we have "Slower (2-5 minutes)", I would think it's closer to "1-3 minutes" but maybe this is based on your experience? But aside from that I think this whole section needs a revisit now with the create+add flow, there isn't a "slower" path now since it's built in to the add pieces operation, so all There's a "Metadata Matching for Cost Efficiency" - you should change the wording here I think to talk about floor pricing, "unnecessary dataset creation costs" -- it's really about "avoiding the minimum data set storage fee of 6¢/month. Last though: I don't know if it's there but a link to Filecoin Pin would be great -- when people want a concept of "files and directories" then Filecoin Pin is the answer to that, a layer on top that brings IPFS's filesystem structure to FOC. That's all for a quick skim for now. Good work so far. Sorry that we have more breakage to come that will change some of this. |
timfong888
left a comment
There was a problem hiding this comment.
- Prerequisites must appear before first code example (getting-started)
- Quick start needs complete runnable example in <5 min (getting-started)
- Replace placeholder null as unknown as bigint with actual API call (payments/index.mdx line 118-139)
-
- Add real-world cost examples:
| import { Synapse } from "@filoz/synapse-sdk"; | ||
| // @ts-ignore | ||
| const synapse = await Synapse.create(); | ||
| const monthlyPricePerTiB = null as unknown as bigint; |
There was a problem hiding this comment.
What does this mean? Can we make as a thing before code is offered for review it works; this seems odd to me.
There was a problem hiding this comment.
Fixed! There is only one place now that uses @ts-ignore and that's because /pieces is not exported in the sdk @rvagg can you export all the pieces utils in the main package without having to import from synapse-sdk/pieces ?
There was a problem hiding this comment.
I'm still a little bit unclear as to keeping const monthlyPricePerTiB = null as unknown as bigint; in the code sample?
|
Thanks, @rvagg, for reviewing it and providing your comments. I have addressed most of your comments but one. @nijoe1 can you revisit the "Creating a Storage Context" section? Since Rod mentioned that after implementing |
Fixed
Fixed
Sorry I do not really understand this. Maybe you can directly add a comment in |
I made major changes in the storage-costs page that I think that they address @rvagg & @timfong888 comments Check it out and let me know for further feedback https://synapse-sdk-docs.netlify.app/developer-guides/storage/storage-costs/ |
I've made updates to the storage-context section. I agree this was outdated and taken from the old docs. I removed it due to the createAndAdd feature. Check the updates here and let me know if it reads better now! https://synapse-sdk-docs.netlify.app/developer-guides/storage/storage-context/ cc: @rvagg |
Fixed. |
Fixed |
Done |
It is not necessary to have a mainnet path in the quick start for builders. Let's keep it simple to educate builders in a quicker way to learn how to build with Synpase. Done |
|
@jennijuju @timfong888 @Kubuxu Thank you for reviewing. All comments are addressed. @timfong888 , can you double-check if those changes are good for your |
- Resolved conflict by removing old gettingStarted/getting-started.mdx - Kept the newer getting-started/index.mdx with comprehensive documentation - Merged updates to storage.mdx, why.mdx, manager.ts, and synapse.test.ts
Completes the comprehensive Filecoin Onchain Cloud documentation, building upon previously refined sections with developer guides and infrastructure improvements. **Related Issues:** - Builds upon #322 (Introduction) - Builds upon #323 (Getting Started) - Builds upon #345 (Core Concepts) - Builds upon #404 (Developer Guides) - Part of #321 (Filecoin Onchain Cloud docs) **Documentation:** - Add comprehensive introduction section and developer guides - Update quickstart guide with improved examples - Add pricing and storage costs documentation - Fix broken links and improve navigation **Other:** - Add mainnet contract addresses - Documentation of synapse-version@0.35.3 - Bug fixes for types and error handling --------- Co-authored-by: longfeiW <longfeiwang.88@gmail.com> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Jennifer Wang <jiayingw703@gmail.com> Co-authored-by: Jakub Sztandera <oss@kubuxu.com>
I had the same comments as well in my original re: prequisits, does this mean this is still opened or it is addressed since it is closed? |
| - Supports both streaming and one-time payments | ||
| - Supports native token streaming | ||
|
|
||
| The real innovation isn't just streaming payments - it's enabling **trustless business relationships** where math and code enforce agreements, eliminating the need for intermediaries and manual oversight. |
There was a problem hiding this comment.
Can we remove this paragraph or make it a little less exuberant?
| - Cryptographic guarantees and verifiable delivery | ||
| - Programmable quality checks with instant consequences | ||
| - Supports both streaming and one-time payments | ||
| - Supports native token streaming |
There was a problem hiding this comment.
What does this really mean ? aren't we doing auto-lockups on an epoch basis? And "native token" sounds like, especially since we are working with chains, they can pay in their native token. Can you confirm we do this? My understanding is we didn.t
| You manually send $100 to a friend once. | ||
|
|
||
| **Filecoin Pay payment rail:** | ||
| You set up an automatic stream of $100/month for 3 months. Payments flow continuously without any manual intervention, with built-in guarantees that protect both parties. |
There was a problem hiding this comment.
Similar here: I think we need to be precise about the word "continuosly"
| By the end of this guide, you'll understand how to: | ||
|
|
||
| - Install and configure the Synapse SDK | ||
| - Connect to Filecoin networks (mainnet and calibration) |
There was a problem hiding this comment.
I don't see mainnet instructions....
| const formattedBalance = ethers.formatUnits(walletBalance, 18); | ||
| console.log(`Wallet USDFC balance: ${formattedBalance} USDFC\n`); | ||
|
|
||
| // Validate sufficient balance before proceeding |
There was a problem hiding this comment.
How do we define "sufficient balance" -- should be both inline and maybe guidance above as a recommended start for clarity.
There was a problem hiding this comment.
maybe it's resolved if we just say up front $5 is for purposes of getting started.
|
|
||
| As the economic core of the Filecoin Onchain Cloud (FOC), **Filecoin Pay** embeds **financial logic directly into on-chain contracts**, ensuring that providers receive funds only when they deliver verifiable service, and clients pay only when conditions are met. | ||
|
|
||
| With Filecoin Pay, service economics become as **transparent and composable** as the data services they underpin, enabling the Filecoin network to operate not just as a storage market but as a fully programmable cloud economy. |
There was a problem hiding this comment.
I don't actually know what this means. It feels wordy. What does the developer do?
|
|
||
| In the Filecoin Onchain Cloud architecture, services (storage, retrieval) must be paired with economic incentives. Without a robust, verifiable settlement layer, the system risks: | ||
|
|
||
| - Providers performing work without guaranteed payment. |
There was a problem hiding this comment.
We shouldn't be talking about problems with our system. Just what they can get and use.
|
|
||
| Filecoin Pay addresses these risks by tying **service delivery** (e.g., proofs of data possession, retrieval success) to **on-chain payment flows** that lets services run automated, controllable payment “rails” between a payer and a payee. It supports: | ||
|
|
||
| - **Token-agnostic billing**: support for FIL, stablecoins, ERC-20 tokens. |
timfong888
left a comment
There was a problem hiding this comment.
I have a number of clarification language, some of it seems too wordy or imprecise, and I called out several examples, but I think this should be reviewed throughout using those as examples.
|
@nijoe1 @timfong888 this is closed but not merged! whats are we doing here ? theres yet another pr opened updating docs #265 |
|
Because we were blocked on merging from Tim's staled review request while he was traveling. I opened a fresh pr and merged it. |
There was a problem hiding this comment.
File: docs/src/content/docs/developer-guides/components.mdx
Lines: ~1478-1481 (in diff)
Placeholder pattern needs explanation.
The pattern const provider = null as unknown as ethers.Provider appears throughout examples without explanation.
What happens if this is run?
Completes the comprehensive Filecoin Onchain Cloud documentation, building upon previously refined sections with developer guides and infrastructure improvements. **Related Issues:** - Builds upon FilOzone#322 (Introduction) - Builds upon FilOzone#323 (Getting Started) - Builds upon FilOzone#345 (Core Concepts) - Builds upon FilOzone#404 (Developer Guides) - Part of FilOzone#321 (Filecoin Onchain Cloud docs) **Documentation:** - Add comprehensive introduction section and developer guides - Update quickstart guide with improved examples - Add pricing and storage costs documentation - Fix broken links and improve navigation **Other:** - Add mainnet contract addresses - Documentation of synapse-version@0.35.3 - Bug fixes for types and error handling --------- Co-authored-by: longfeiW <longfeiwang.88@gmail.com> Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Jennifer Wang <jiayingw703@gmail.com> Co-authored-by: Jakub Sztandera <oss@kubuxu.com>
Overview
Implements comprehensive developer guides for Synapse SDK covering basic and advanced storage and payment operations. This PR builds upon previously refined documentation sections (introduction, getting-started, and core concepts) and includes overall documentation infrastructure improvements.
📖 Live Preview: https://synapse-sdk-docs.netlify.app/
Related Issues
Main Scope: Developer Guides
Key Feature: TypeScript Twoslash Integration
Additional Improvements