internal/format: bound header size during Parse#699
Open
sweis wants to merge 1 commit intoFiloSottile:mainfrom
Open
internal/format: bound header size during Parse#699sweis wants to merge 1 commit intoFiloSottile:mainfrom
sweis wants to merge 1 commit intoFiloSottile:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format.Parseaccumulates stanza bodies with no cap on total header bytes, soa crafted header can exhaust memory in an automated
age.Decryptcaller beforeany MAC is checked.
Fix: wrap the input in a counting reader that errors at 16 MiB. The payload
reader is reconstituted from bufio's overread prepended to the original input
as before; the
rr == inputshort-circuit is removed since the wrapper makesit unreachable.
Test:
go test ./internal/format/ -run TestParseHeaderSizeLimit -v(feeds an infinite-stanza-body reader; pre-fix this would read forever.)