-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps) Unpin eslint-config-next for Next.js framework tests
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the security and maintainability of the Next.js framework tests by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the eslint-config-next dependency from a pinned version to latest to resolve a security vulnerability. While this change is necessary and makes the dependency consistent with others in the package, using latest can introduce build instability. I've suggested using a caret version range instead to ensure more predictable dependency resolution while still allowing for non-breaking updates.
| "@types/react": "latest", | ||
| "eslint": "^8", | ||
| "eslint-config-next": "15.5.2", | ||
| "eslint-config-next": "latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While using "latest" resolves the immediate security issue and aligns with the practice for other dependencies in this test package, it introduces a risk of non-reproducible builds and unexpected breaking changes. It's generally better to pin to a specific version or use a version range. Since yarn.lock shows that latest currently resolves to 16.0.7, I suggest using a caret range to allow for non-breaking updates while preventing major version changes.
| "eslint-config-next": "latest", | |
| "eslint-config-next": "^16.0.7", |
TLDR; This change changes our dev dependencies to use the latest version of
eslint-config-next.We had a floating dependency on Next.js, which would grab the latest version to test against. However, we had pinned our
eslint-config-nextto a particular version.It turns out that particular version pulled in a Next.js dependency that contained a security vulnerability.