Skip to content

Conversation

@DellaBitta
Copy link
Collaborator

TLDR; This change changes our dev dependencies to use the latest version of eslint-config-next.

We had a floating dependency on Next.js, which would grab the latest version to test against. However, we had pinned our eslint-config-next to a particular version.

It turns out that particular version pulled in a Next.js dependency that contained a security vulnerability.

@gemini-code-assist
Copy link

Summary of Changes

Hello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security and maintainability of the Next.js framework tests by updating the eslint-config-next development dependency. The primary motivation is to resolve a security vulnerability present in an older, pinned version of this configuration. By switching to the latest version, the project benefits from the most recent security patches and ensures compatibility with current Next.js practices, leading to a more robust and secure development environment.

Highlights

  • Dependency Update: The eslint-config-next dependency has been unpinned and updated to its latest version in js-sdk-framework-tests/nextjs/package.json.
  • Security Fix: This update addresses a security vulnerability found in a transitive dependency of the previously pinned eslint-config-next version, enhancing the project's security posture.
  • Lock File Regeneration: The yarn.lock file has been regenerated to reflect the updated eslint-config-next and its associated transitive dependencies, including various ESLint plugins, Babel packages, and TypeScript-related packages.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the eslint-config-next dependency from a pinned version to latest to resolve a security vulnerability. While this change is necessary and makes the dependency consistent with others in the package, using latest can introduce build instability. I've suggested using a caret version range instead to ensure more predictable dependency resolution while still allowing for non-breaking updates.

"@types/react": "latest",
"eslint": "^8",
"eslint-config-next": "15.5.2",
"eslint-config-next": "latest",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using "latest" resolves the immediate security issue and aligns with the practice for other dependencies in this test package, it introduces a risk of non-reproducible builds and unexpected breaking changes. It's generally better to pin to a specific version or use a version range. Since yarn.lock shows that latest currently resolves to 16.0.7, I suggest using a caret range to allow for non-breaking updates while preventing major version changes.

Suggested change
"eslint-config-next": "latest",
"eslint-config-next": "^16.0.7",

@DellaBitta DellaBitta merged commit 173e656 into main Dec 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants