feat: Add lifecycle hooks, terminationGracePeriodSeconds#508
Merged
emyller merged 1 commit intoFlagsmith:mainfrom Mar 18, 2026
Merged
feat: Add lifecycle hooks, terminationGracePeriodSeconds#508emyller merged 1 commit intoFlagsmith:mainfrom
terminationGracePeriodSeconds#508emyller merged 1 commit intoFlagsmith:mainfrom
Conversation
terminationGracePeriodSeconds
khvn26
approved these changes
Mar 18, 2026
emyller
approved these changes
Mar 18, 2026
Contributor
emyller
left a comment
There was a problem hiding this comment.
Thank you for the contribution! This is helpful and much appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for container
lifecyclehooks and podterminationGracePeriodSecondsto all 4 application deployment templates: API, TaskProcessor, Frontend, and SSE.Currently the PgBouncer deployment template has a hardcoded
preStoplifecycle hook, but none of the application deployments support configuring lifecycle hooks or termination grace periods via values.Closes #507
Changes
templates/deployment-api.yaml: AddlifecycleandterminationGracePeriodSecondstemplates/deployment-task-processor.yaml: AddlifecycleandterminationGracePeriodSecondstemplates/deployment-frontend.yaml: AddlifecycleandterminationGracePeriodSecondstemplates/deployment-sse.yaml: AddlifecycleandterminationGracePeriodSecondsvalues.yaml: Add default values (lifecycle: {},terminationGracePeriodSeconds: null) for all 4 componentsUsage Example
Backward Compatibility
lifecycle: {}andterminationGracePeriodSeconds: null, which means no change to existing deployments{{- with }}/{{- if }}) so they are omitted entirely when not setTesting
Verified with
helm templatethat:lifecycleandterminationGracePeriodSecondscorrectly when set