Fix false passes when commands are rejected - #17
Open
kdcokenny wants to merge 2 commits into
Open
Conversation
Author
|
is modifying the workflow out of scope? lmk if so, i'll rm it |
coco875
reviewed
Aug 13, 2026
coco875
reviewed
Aug 13, 2026
| - name: Run FlintMC Tests | ||
| run: | | ||
| # Run all example tests | ||
| cargo run -- FlintBenchmark/tests/ --server localhost:25565 --recursive --verbose |
Contributor
There was a problem hiding this comment.
I want this to still run to confirm that test added in FlintBenchmark still work against vanilla
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlintCLI no longer treats the receipt marker as proof that the command worked.
Tested with:
FLINTMC_TEST_SERVER=localhost:25565 cargo test --locked -- --include-ignored --test-threads=1