Upgrade ty to 0.0.49 and fix src type-check errors#70
Merged
Conversation
Extend CMAKE_CUDA_ARCHITECTURES and runtime CC check to support Pascal GPUs. Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This reverts commit bda34da.
array_api_strict arrays lack .astype (uses namespace xp.astype instead), which broke runtime isinstance/beartype checks in tests. Move astype to _ArrayNamespace per the Array API spec and cast at the kernel boundary. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace cast(Any, arr).astype(...) with namespace-level xp.astype per the Array API spec, using the _ArrayNamespace Protocol we already declare. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tyfrom0.0.1a14to0.0.49and resolve allty check srcdiagnosticsArrayProtocol with Array API positional-only method signatures (/), addastypeand__setitem__, and extend_ArrayNamespacewithascontiguousarrayisinstance(..., Num[Array, ...])checks inkernel.pywith Protocol + dtype-kind validation; cast at the nanobind boundarygeometry.pyreturn typing (types.ModuleTypeinstead oftype[math])Test plan
ty check srcpasses locallymake checkpassesMade with Cursor